Diff
Modified: trunk/Source/WebCore/ChangeLog (124930 => 124931)
--- trunk/Source/WebCore/ChangeLog 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/ChangeLog 2012-08-07 22:56:02 UTC (rev 124931)
@@ -1,5 +1,34 @@
2012-08-07 Kentaro Hara <[email protected]>
+ [V8] Remove #include Frame.h from V8Binding.h
+ https://bugs.webkit.org/show_bug.cgi?id=93326
+
+ Reviewed by Adam Barth.
+
+ We want to remove unnecessary #include in V8Binding.h
+ to avoid circular include dependency.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateDomainSafeFunctionGetter):
+ (GenerateNormalAttrGetter):
+ (GenerateReplaceableAttrSetter):
+ (GenerateFunctionCallback):
+ (GenerateNamedConstructorCallback):
+ (GenerateToV8Converters):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
+ * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
+ * bindings/scripts/test/V8/V8TestNode.cpp:
+ * bindings/v8/ScheduledAction.cpp:
+ * bindings/v8/V8Binding.h:
+ * bindings/v8/V8DOMWrapper.cpp:
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ * bindings/v8/custom/V8SVGDocumentCustom.cpp:
+ * testing/v8/WebCoreTestSupport.cpp:
+
+2012-08-07 Kentaro Hara <[email protected]>
+
[V8] Factor out V8Binding classes that manage V8 value's cache
https://bugs.webkit.org/show_bug.cgi?id=93343
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (124930 => 124931)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-08-07 22:56:02 UTC (rev 124931)
@@ -756,6 +756,7 @@
my $newTemplateString = GenerateNewFunctionTemplate($function, $implClassName, $signature);
+ AddToImplIncludes("Frame.h");
push(@implContentDecls, <<END);
static v8::Handle<v8::Value> ${funcName}AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
@@ -995,6 +996,7 @@
push(@implContentDecls, " wrapper = toV8(result.get(), info.GetIsolate());\n");
push(@implContentDecls, " if (!wrapper.IsEmpty())\n");
if ($dataNode->name eq "DOMWindow") {
+ AddToImplIncludes("Frame.h");
push(@implContentDecls, " V8DOMWrapper::setNamedHiddenWindowReference(imp->frame(), \"${attrName}\", wrapper);\n");
} else {
push(@implContentDecls, " V8DOMWrapper::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n");
@@ -1091,6 +1093,7 @@
END
if ($implClassName eq "DOMWindow" || $dataNode->extendedAttributes->{"CheckSecurity"}) {
+ AddToImplIncludes("Frame.h");
push(@implContentDecls, <<END);
${implClassName}* imp = V8${implClassName}::toNative(info.Holder());
if (!BindingSecurity::shouldAllowAccessToFrame(BindingState::instance(), imp->frame()))
@@ -1499,6 +1502,7 @@
|| $interfaceName eq "DOMWindow")
&& !$function->signature->extendedAttributes->{"DoNotCheckSecurity"}) {
# We have not find real use cases yet.
+ AddToImplIncludes("Frame.h");
push(@implContentDecls, <<END);
if (!BindingSecurity::shouldAllowAccessToFrame(BindingState::instance(), imp->frame()))
return v8Undefined();
@@ -1964,6 +1968,7 @@
END
}
+ AddToImplIncludes("Frame.h");
push(@implContent, <<END);
static v8::Handle<v8::Value> V8${implClassName}ConstructorCallback(const v8::Arguments& args)
{
@@ -3310,6 +3315,7 @@
my $proxyInit;
if (IsNodeSubType($dataNode)) {
+ AddToImplIncludes("Frame.h");
$proxyInit = "impl->document()->frame() ? impl->document()->frame()->script()->proxy() : 0";
# DocumentType nodes are the only nodes that may have a NULL document.
if ($interfaceName eq "DocumentType") {
@@ -3335,6 +3341,7 @@
# for every sort of object. For now, we special-case cross-origin visible
# objects (i.e., those with CheckSecurity).
if (IsVisibleAcrossOrigins($dataNode)) {
+ AddToImplIncludes("Frame.h");
push(@implContent, <<END);
if (impl->frame()) {
proxy = impl->frame()->script()->proxy();
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -24,6 +24,7 @@
#include "BindingState.h"
#include "ContextFeatures.h"
#include "ExceptionCode.h"
+#include "Frame.h"
#include "RuntimeEnabledFeatures.h"
#include "V8Binding.h"
#include "V8BindingMacros.h"
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -24,6 +24,7 @@
#include "BindingState.h"
#include "ContextFeatures.h"
#include "ExceptionCode.h"
+#include "Frame.h"
#include "RuntimeEnabledFeatures.h"
#include "V8Binding.h"
#include "V8BindingMacros.h"
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -23,6 +23,7 @@
#include "BindingState.h"
#include "ContextFeatures.h"
+#include "Frame.h"
#include "RuntimeEnabledFeatures.h"
#include "V8Binding.h"
#include "V8DOMWrapper.h"
Modified: trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/v8/ScheduledAction.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -32,6 +32,7 @@
#include "ScheduledAction.h"
#include "Document.h"
+#include "Frame.h"
#include "ScriptExecutionContext.h"
#include "ScriptSourceCode.h"
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (124930 => 124931)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-08-07 22:56:02 UTC (rev 124931)
@@ -34,7 +34,6 @@
#include "BindingSecurity.h"
#include "DOMDataStore.h"
#include "Document.h"
-#include "Frame.h"
#include "PlatformString.h"
#include "V8BindingMacros.h"
#include "V8DOMWrapper.h"
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -35,6 +35,7 @@
#include "DocumentLoader.h"
#include "EventTargetHeaders.h"
#include "EventTargetInterfaces.h"
+#include "Frame.h"
#include "FrameLoaderClient.h"
#include "SafeAllocation.h"
#include "StylePropertySet.h"
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -34,6 +34,7 @@
#include "CanvasRenderingContext.h"
#include "Document.h"
#include "ExceptionCode.h"
+#include "Frame.h"
#include "Node.h"
#include "TouchList.h"
#include "XPathNSResolver.h"
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp (124930 => 124931)
--- trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -33,6 +33,7 @@
#if ENABLE(SVG)
#include "V8SVGDocument.h"
+#include "Frame.h"
#include "V8IsolatedContext.h"
#include "V8Proxy.h"
Modified: trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp (124930 => 124931)
--- trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebCore/testing/v8/WebCoreTestSupport.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -27,6 +27,7 @@
#include "WebCoreTestSupport.h"
#include "Document.h"
+#include "Frame.h"
#include "InternalSettings.h"
#include "Internals.h"
#include "ScriptExecutionContext.h"
Modified: trunk/Source/WebKit/chromium/ChangeLog (124930 => 124931)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-07 22:56:02 UTC (rev 124931)
@@ -1,3 +1,17 @@
+2012-08-07 Kentaro Hara <[email protected]>
+
+ [V8] Remove #include Frame.h from V8Binding.h
+ https://bugs.webkit.org/show_bug.cgi?id=93326
+
+ Reviewed by Adam Barth.
+
+ We want to remove unnecessary #include in V8Binding.h
+ to avoid circular include dependency.
+
+ No tests. No change in behavior.
+
+ * src/WebBindings.cpp:
+
2012-08-07 James Robinson <[email protected]>
[chromium] Switch PlatformLayer typedef to Platform API type for PLATFORM(CHROMIUM)
Modified: trunk/Source/WebKit/chromium/src/WebBindings.cpp (124930 => 124931)
--- trunk/Source/WebKit/chromium/src/WebBindings.cpp 2012-08-07 22:55:04 UTC (rev 124930)
+++ trunk/Source/WebKit/chromium/src/WebBindings.cpp 2012-08-07 22:56:02 UTC (rev 124931)
@@ -37,6 +37,7 @@
#if USE(V8)
#include "BindingState.h"
#include "DOMWindow.h"
+#include "Frame.h"
#include "NPV8Object.h" // for PrivateIdentifier
#include "Range.h"
#include "V8ArrayBuffer.h"
