Title: [124952] trunk/Source
- Revision
- 124952
- Author
- hara...@chromium.org
- Date
- 2012-08-07 17:44:14 -0700 (Tue, 07 Aug 2012)
Log Message
[V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods
https://bugs.webkit.org/show_bug.cgi?id=93209
Reviewed by Adam Barth.
By implementing V8Proxy::registerExtensionIfNeeded(), we can remove
registeredExtensionWithV8() and registerExtension().
No tests. No change in behavior.
Source/WebCore:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::registerExtensionIfNeeded):
* bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
* src/WebScriptController.cpp:
(WebKit::WebScriptController::registerExtension):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124951 => 124952)
--- trunk/Source/WebCore/ChangeLog 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebCore/ChangeLog 2012-08-08 00:44:14 UTC (rev 124952)
@@ -1,3 +1,22 @@
+2012-08-07 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods
+ https://bugs.webkit.org/show_bug.cgi?id=93209
+
+ Reviewed by Adam Barth.
+
+ By implementing V8Proxy::registerExtensionIfNeeded(), we can remove
+ registeredExtensionWithV8() and registerExtension().
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8DOMWindowShell.cpp:
+ (WebCore::V8DOMWindowShell::createNewContext):
+ * bindings/v8/V8Proxy.cpp:
+ (WebCore::V8Proxy::registerExtensionIfNeeded):
+ * bindings/v8/V8Proxy.h:
+ (V8Proxy):
+
2012-08-07 Ryuan Choi <ryuan.c...@samsung.com>
[EFL] Remove PlatformTouchEventEfl and PlatformTouchPointEfl
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (124951 => 124952)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-08 00:44:14 UTC (rev 124952)
@@ -366,13 +366,12 @@
return result;
// Used to avoid sleep calls in unload handlers.
- if (!V8Proxy::registeredExtensionWithV8(DateExtension::get()))
- V8Proxy::registerExtension(DateExtension::get());
+ V8Proxy::registerExtensionIfNeeded(DateExtension::get());
#if ENABLE(_javascript__I18N_API)
// Enables experimental i18n API in V8.
- if (RuntimeEnabledFeatures::_javascript_I18NAPIEnabled() && !V8Proxy::registeredExtensionWithV8(v8_i18n::Extension::get()))
- V8Proxy::registerExtension(v8_i18n::Extension::get());
+ if (RuntimeEnabledFeatures::_javascript_I18NAPIEnabled())
+ V8Proxy::registerExtensionIfNeeded(v8_i18n::Extension::get());
#endif
// Dynamically tell v8 about our extensions now.
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (124951 => 124952)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2012-08-08 00:44:14 UTC (rev 124952)
@@ -634,22 +634,14 @@
return extensions;
}
-bool V8Proxy::registeredExtensionWithV8(v8::Extension* extension)
+void V8Proxy::registerExtensionIfNeeded(v8::Extension* extension)
{
const V8Extensions& registeredExtensions = extensions();
for (size_t i = 0; i < registeredExtensions.size(); ++i) {
if (registeredExtensions[i] == extension)
- return true;
+ return;
}
-
- return false;
-}
-
-void V8Proxy::registerExtension(v8::Extension* extension)
-{
- // If the extension exists in our list, it was already registered with V8.
- if (!registeredExtensionWithV8(extension))
- v8::RegisterExtension(extension);
+ v8::RegisterExtension(extension);
extensions().append(extension);
}
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (124951 => 124952)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-08-08 00:44:14 UTC (rev 124952)
@@ -166,9 +166,7 @@
// Registers a v8 extension to be available on webpages. Will only
// affect v8 contexts initialized after this call. Takes ownership of
// the v8::Extension object passed.
- static void registerExtension(v8::Extension*);
- static bool registeredExtensionWithV8(v8::Extension*);
-
+ static void registerExtensionIfNeeded(v8::Extension*);
static V8Extensions& extensions();
static void reportUnsafeAccessTo(Document* targetDocument);
Modified: trunk/Source/WebKit/chromium/ChangeLog (124951 => 124952)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-08 00:44:14 UTC (rev 124952)
@@ -1,3 +1,18 @@
+2012-08-07 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods
+ https://bugs.webkit.org/show_bug.cgi?id=93209
+
+ Reviewed by Adam Barth.
+
+ By implementing V8Proxy::registerExtensionIfNeeded(), we can remove
+ registeredExtensionWithV8() and registerExtension().
+
+ No tests. No change in behavior.
+
+ * src/WebScriptController.cpp:
+ (WebKit::WebScriptController::registerExtension):
+
2012-08-07 James Robinson <jam...@chromium.org>
[chromium] Add new gclient-managed cc directory to Source/WebKit/chromium/.gitignore
Modified: trunk/Source/WebKit/chromium/src/WebScriptController.cpp (124951 => 124952)
--- trunk/Source/WebKit/chromium/src/WebScriptController.cpp 2012-08-08 00:18:06 UTC (rev 124951)
+++ trunk/Source/WebKit/chromium/src/WebScriptController.cpp 2012-08-08 00:44:14 UTC (rev 124952)
@@ -43,7 +43,7 @@
void WebScriptController::registerExtension(v8::Extension* extension)
{
- V8Proxy::registerExtension(extension);
+ V8Proxy::registerExtensionIfNeeded(extension);
}
void WebScriptController::enableV8SingleThreadMode()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
