Title: [125090] trunk/PerformanceTests
- Revision
- 125090
- Author
- [email protected]
- Date
- 2012-08-08 14:48:38 -0700 (Wed, 08 Aug 2012)
Log Message
Calling internals from the performance test runner prevents manual running
https://bugs.webkit.org/show_bug.cgi?id=93527
Reviewed by Ryosuke Niwa.
Since r125065, it is impossible to run the Performance tests manually. The problem is
"internals" is not defined when running outside the test runner, so the whole script
evaluation fails.
* resources/runner.js: Verify is window.internals is available before invoking something on it.
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (125089 => 125090)
--- trunk/PerformanceTests/ChangeLog 2012-08-08 21:19:40 UTC (rev 125089)
+++ trunk/PerformanceTests/ChangeLog 2012-08-08 21:48:38 UTC (rev 125090)
@@ -1,3 +1,16 @@
+2012-08-08 Benjamin Poulain <[email protected]>
+
+ Calling internals from the performance test runner prevents manual running
+ https://bugs.webkit.org/show_bug.cgi?id=93527
+
+ Reviewed by Ryosuke Niwa.
+
+ Since r125065, it is impossible to run the Performance tests manually. The problem is
+ "internals" is not defined when running outside the test runner, so the whole script
+ evaluation fails.
+
+ * resources/runner.js: Verify is window.internals is available before invoking something on it.
+
2012-08-08 Zoltan Horvath <[email protected]>
Set access to MemoryInfo enabled for the performance tests
Modified: trunk/PerformanceTests/resources/runner.js (125089 => 125090)
--- trunk/PerformanceTests/resources/runner.js 2012-08-08 21:19:40 UTC (rev 125089)
+++ trunk/PerformanceTests/resources/runner.js 2012-08-08 21:48:38 UTC (rev 125090)
@@ -1,7 +1,8 @@
// There are tests for computeStatistics() located in LayoutTests/fast/harness/perftests
// We need access to console.memory for the memory measurements
-internals.settings.setMemoryInfoEnabled(true);
+if (window.internals)
+ internals.settings.setMemoryInfoEnabled(true);
var PerfTestRunner = {};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
