Title: [125100] trunk/Source/WebKit2
- Revision
- 125100
- Author
- [email protected]
- Date
- 2012-08-08 15:16:35 -0700 (Wed, 08 Aug 2012)
Log Message
REGRESSION: Crash when plug-in initialization fails
https://bugs.webkit.org/show_bug.cgi?id=93534
<rdar://problem/12059786>
Reviewed by Simon Fraser.
Protect the PluginProxy while calling out to functions that could cause it to be destroyed.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::didFailToCreatePluginInternal):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (125099 => 125100)
--- trunk/Source/WebKit2/ChangeLog 2012-08-08 22:13:19 UTC (rev 125099)
+++ trunk/Source/WebKit2/ChangeLog 2012-08-08 22:16:35 UTC (rev 125100)
@@ -1,5 +1,18 @@
2012-08-08 Anders Carlsson <[email protected]>
+ REGRESSION: Crash when plug-in initialization fails
+ https://bugs.webkit.org/show_bug.cgi?id=93534
+ <rdar://problem/12059786>
+
+ Reviewed by Simon Fraser.
+
+ Protect the PluginProxy while calling out to functions that could cause it to be destroyed.
+
+ * WebProcess/Plugins/PluginProxy.cpp:
+ (WebKit::PluginProxy::didFailToCreatePluginInternal):
+
+2012-08-08 Anders Carlsson <[email protected]>
+
Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors
https://bugs.webkit.org/show_bug.cgi?id=93532
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (125099 => 125100)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2012-08-08 22:13:19 UTC (rev 125099)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2012-08-08 22:16:35 UTC (rev 125100)
@@ -185,6 +185,9 @@
void PluginProxy::didFailToCreatePluginInternal()
{
+ // Calling out to the connection and the controller could potentially cause the plug-in proxy to go away, so protect it here.
+ RefPtr<PluginProxy> protect(this);
+
m_connection->removePluginProxy(this);
controller()->didFailToInitializePlugin();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
