Title: [125181] trunk/Source/WebCore
- Revision
- 125181
- Author
- [email protected]
- Date
- 2012-08-09 10:11:54 -0700 (Thu, 09 Aug 2012)
Log Message
REGRESSION (r124997): Flaky crashes in two tests
https://bugs.webkit.org/show_bug.cgi?id=93501
Reviewed by Martin Robinson.
Add missing null check to make sure we early return if the
accessibility object does not have a valid parent exposed in the
accessibility hierarchy.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Add missing null check.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125180 => 125181)
--- trunk/Source/WebCore/ChangeLog 2012-08-09 17:10:02 UTC (rev 125180)
+++ trunk/Source/WebCore/ChangeLog 2012-08-09 17:11:54 UTC (rev 125181)
@@ -1,3 +1,17 @@
+2012-08-09 Mario Sanchez Prada <[email protected]>
+
+ REGRESSION (r124997): Flaky crashes in two tests
+ https://bugs.webkit.org/show_bug.cgi?id=93501
+
+ Reviewed by Martin Robinson.
+
+ Add missing null check to make sure we early return if the
+ accessibility object does not have a valid parent exposed in the
+ accessibility hierarchy.
+
+ * accessibility/gtk/AXObjectCacheAtk.cpp:
+ (WebCore::emitTextChanged): Add missing null check.
+
2012-08-09 Pavel Feldman <[email protected]>
Web Inspector: generate preview for the objects dumped into the console upon logging.
Modified: trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp (125180 => 125181)
--- trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-08-09 17:10:02 UTC (rev 125180)
+++ trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-08-09 17:11:54 UTC (rev 125181)
@@ -160,7 +160,11 @@
static void emitTextChanged(AccessibilityObject* object, AXObjectCache::AXTextChange textChange, unsigned offset, const String& text)
{
- AtkObject* wrapper = object->parentObjectUnignored()->wrapper();
+ AccessibilityObject* parentObject = object->parentObjectUnignored();
+ if (!parentObject)
+ return;
+
+ AtkObject* wrapper = parentObject->wrapper();
if (!wrapper || !ATK_IS_TEXT(wrapper))
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
