[webkit-changes] [125188] trunk/Tools

Thu, 09 Aug 2012 11:27:44 -0700

Title: [125188] trunk/Tools
Revision
125188
Author
[email protected]
Date
2012-08-09 11:27:46 -0700 (Thu, 09 Aug 2012)

Log Message

Build fix after r125178.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output): Don't include non-time results in the JSON output.
* Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
actual test outputs.
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (125187 => 125188)


--- trunk/Tools/ChangeLog	2012-08-09 18:07:00 UTC (rev 125187)
+++ trunk/Tools/ChangeLog	2012-08-09 18:27:46 UTC (rev 125188)
@@ -1,3 +1,15 @@
+2012-08-09  Ryosuke Niwa  <[email protected]>
+
+        Build fix after r125178.
+
+        * Scripts/webkitpy/performance_tests/perftest.py:
+        (PerfTest.parse_output): Don't include non-time results in the JSON output.
+        * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
+        actual test outputs.
+        (MainTest.test_parse_output):
+        (MainTest.test_parse_output_with_failing_line):
+        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
+
 2012-08-09  Zoltan Horvath  <[email protected]>
 
         JSHeap and FastMallocStatistics based memory measurement for performance-tests

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (125187 => 125188)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-08-09 18:07:00 UTC (rev 125187)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-08-09 18:27:46 UTC (rev 125188)
@@ -156,7 +156,7 @@
         if results[self._result_classes[1]] and results[self._result_classes[2]]:
             self.output_statistics(test_name + "/JSHeap", results[self._result_classes[1]])
             self.output_statistics(test_name + "/FastMalloc", results[self._result_classes[2]])
-        return {test_name: results}
+        return {test_name: results['Time:']}
 
     def output_statistics(self, test_name, results, description_string=None):
         unit = results['unit']

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py (125187 => 125188)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py	2012-08-09 18:07:00 UTC (rev 125187)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py	2012-08-09 18:27:46 UTC (rev 125188)
@@ -49,11 +49,12 @@
             'Running 20 times',
             'Ignoring warm-up run (1115)',
             '',
-            'avg 1100',
-            'median 1101',
-            'stdev 11',
-            'min 1080',
-            'max 1120']), image=None, image_hash=None, audio=None)
+            'Time:',
+            'avg 1100 ms',
+            'median 1101 ms',
+            'stdev 11 ms',
+            'min 1080 ms',
+            'max 1120 ms']), image=None, image_hash=None, audio=None)
         output_capture = OutputCapture()
         output_capture.capture_output()
         try:
@@ -61,6 +62,7 @@
             self.assertEqual(test.parse_output(output),
                 {'some-test': {'avg': 1100.0, 'median': 1101.0, 'min': 1080.0, 'max': 1120.0, 'stdev': 11.0, 'unit': 'ms'}})
         finally:
+            pass
             actual_stdout, actual_stderr, actual_logs = output_capture.restore_output()
         self.assertEqual(actual_stdout, '')
         self.assertEqual(actual_stderr, '')
@@ -73,11 +75,12 @@
             '',
             'some-unrecognizable-line',
             '',
-            'avg 1100',
-            'median 1101',
-            'stdev 11',
-            'min 1080',
-            'max 1120']), image=None, image_hash=None, audio=None)
+            'Time:'
+            'avg 1100 ms',
+            'median 1101 ms',
+            'stdev 11 ms',
+            'min 1080 ms',
+            'max 1120 ms']), image=None, image_hash=None, audio=None)
         output_capture = OutputCapture()
         output_capture.capture_output()
         try:

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (125187 => 125188)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-08-09 18:07:00 UTC (rev 125187)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-08-09 18:27:46 UTC (rev 125188)
@@ -87,21 +87,23 @@
 1475
 1471
 
-avg 1489.05
-median 1487
-stdev 14.46
-min 1471
-max 1510
+Time:
+avg 1489.05 ms
+median 1487 ms
+stdev 14.46 ms
+min 1471 ms
+max 1510 ms
 """
             elif driver_input.test_name.endswith('some-parser.html'):
                 text = """Running 20 times
 Ignoring warm-up run (1115)
 
-avg 1100
-median 1101
-stdev 11
-min 1080
-max 1120
+Time:
+avg 1100 ms
+median 1101 ms
+stdev 11 ms
+min 1080 ms
+max 1120 ms
 """
             return DriverOutput(text, '', '', '', crash=crash, timeout=timeout)
 

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to