- Revision
- 125280
- Author
- [email protected]
- Date
- 2012-08-10 08:20:41 -0700 (Fri, 10 Aug 2012)
Log Message
Change Notification.permissionLevel() to Notification.permission
https://bugs.webkit.org/show_bug.cgi?id=88919
<rdar://problem/11650319>
Reviewed by Kentaro Hara.
Source/WebCore:
Retrieving the permission level has changed to Notification.permission, per this discussion:
http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html
Test: fast/notifications/notifications-permission.html
* Modules/notifications/Notification.cpp: Rename to match attribute name.
(WebCore::Notification::permission):
* Modules/notifications/Notification.h: Rename to match attribute name.
(Notification):
* Modules/notifications/Notification.idl: Change to static readonly attribute.
LayoutTests:
* fast/notifications/notifications-permission-expected.txt: Added.
* fast/notifications/notifications-permission.html: Added.
* platform/chromium/TestExpectations: V8 does not properly support IDL static
attributes. This is tracked in bug 93488.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (125279 => 125280)
--- trunk/LayoutTests/ChangeLog 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/LayoutTests/ChangeLog 2012-08-10 15:20:41 UTC (rev 125280)
@@ -1,3 +1,16 @@
+2012-08-10 Jon Lee <[email protected]>
+
+ Change Notification.permissionLevel() to Notification.permission
+ https://bugs.webkit.org/show_bug.cgi?id=88919
+ <rdar://problem/11650319>
+
+ Reviewed by Kentaro Hara.
+
+ * fast/notifications/notifications-permission-expected.txt: Added.
+ * fast/notifications/notifications-permission.html: Added.
+ * platform/chromium/TestExpectations: V8 does not properly support IDL static
+ attributes. This is tracked in bug 93488.
+
2012-08-10 Andrey Kosyakov <[email protected]>
Web Inspector: add frame ids to TimeStamp, Time and TimeEnd records in Timeline
Added: trunk/LayoutTests/fast/notifications/notifications-permission-expected.txt (0 => 125280)
--- trunk/LayoutTests/fast/notifications/notifications-permission-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/notifications/notifications-permission-expected.txt 2012-08-10 15:20:41 UTC (rev 125280)
@@ -0,0 +1,10 @@
+Check for existence of Notification.permission
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS window.Notification is defined.
+PASS window.Notification.permission is defined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/notifications/notifications-permission.html (0 => 125280)
--- trunk/LayoutTests/fast/notifications/notifications-permission.html (rev 0)
+++ trunk/LayoutTests/fast/notifications/notifications-permission.html 2012-08-10 15:20:41 UTC (rev 125280)
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <script src=""
+</head>
+
+<body>
+<div id="description"></div>
+<div id="console"></div>
+
+<script type="text/_javascript_">
+description("Check for existence of Notification.permission");
+
+shouldBeDefined("window.Notification");
+shouldBeDefined("window.Notification.permission");
+
+var successfullyParsed = true;
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125279 => 125280)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-10 15:20:41 UTC (rev 125280)
@@ -3471,3 +3471,7 @@
// Should only need rebaselining after bug 93558, if both squares are fully green.
BUGWK93558 : compositing/masks/layer-mask-placement.html = IMAGE
+
+// V8 does not support static attributes
+BUGWK93488 SKIP : fast/notifications/notifications-permission.html = TEXT
+
Modified: trunk/Source/WebCore/ChangeLog (125279 => 125280)
--- trunk/Source/WebCore/ChangeLog 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/Source/WebCore/ChangeLog 2012-08-10 15:20:41 UTC (rev 125280)
@@ -1,3 +1,22 @@
+2012-08-10 Jon Lee <[email protected]>
+
+ Change Notification.permissionLevel() to Notification.permission
+ https://bugs.webkit.org/show_bug.cgi?id=88919
+ <rdar://problem/11650319>
+
+ Reviewed by Kentaro Hara.
+
+ Retrieving the permission level has changed to Notification.permission, per this discussion:
+ http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html
+
+ Test: fast/notifications/notifications-permission.html
+
+ * Modules/notifications/Notification.cpp: Rename to match attribute name.
+ (WebCore::Notification::permission):
+ * Modules/notifications/Notification.h: Rename to match attribute name.
+ (Notification):
+ * Modules/notifications/Notification.idl: Change to static readonly attribute.
+
2012-08-10 Kentaro Hara <[email protected]>
[V8] Remove collectIsolatedContexts() from V8Proxy
Modified: trunk/Source/WebCore/Modules/notifications/Notification.cpp (125279 => 125280)
--- trunk/Source/WebCore/Modules/notifications/Notification.cpp 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/Source/WebCore/Modules/notifications/Notification.cpp 2012-08-10 15:20:41 UTC (rev 125280)
@@ -254,7 +254,7 @@
#if ENABLE(NOTIFICATIONS)
-const String& Notification::permissionLevel(ScriptExecutionContext* context)
+const String& Notification::permission(ScriptExecutionContext* context)
{
ASSERT(context->isDocument());
ASSERT(static_cast<Document*>(context)->page());
Modified: trunk/Source/WebCore/Modules/notifications/Notification.h (125279 => 125280)
--- trunk/Source/WebCore/Modules/notifications/Notification.h 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/Source/WebCore/Modules/notifications/Notification.h 2012-08-10 15:20:41 UTC (rev 125280)
@@ -138,7 +138,7 @@
void finalize();
#if ENABLE(NOTIFICATIONS)
- static const String& permissionLevel(ScriptExecutionContext*);
+ static const String& permission(ScriptExecutionContext*);
static const String& permissionString(NotificationClient::Permission);
static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>);
#endif
Modified: trunk/Source/WebCore/Modules/notifications/Notification.idl (125279 => 125280)
--- trunk/Source/WebCore/Modules/notifications/Notification.idl 2012-08-10 15:16:22 UTC (rev 125279)
+++ trunk/Source/WebCore/Modules/notifications/Notification.idl 2012-08-10 15:20:41 UTC (rev 125280)
@@ -52,7 +52,7 @@
#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS
- [CallWith=ScriptExecutionContext] static DOMString permissionLevel();
+ static readonly attribute [CallWith=ScriptExecutionContext] DOMString permission;
[Custom] static void requestPermission(in NotificationPermissionCallback callback);
#endif
