Title: [125290] trunk/Source/_javascript_Core
Revision
125290
Author
[email protected]
Date
2012-08-10 09:21:25 -0700 (Fri, 10 Aug 2012)

Log Message

[BlackBerry] GCActivityCallback should always schedule GC even allocated bytes is a small number
https://bugs.webkit.org/show_bug.cgi?id=93650

Patch by Yong Li <[email protected]> on 2012-08-10
Reviewed by Rob Buis.

Even a small number of allocated JS objects could hold expensive resources.

* runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (125289 => 125290)


--- trunk/Source/_javascript_Core/ChangeLog	2012-08-10 16:15:59 UTC (rev 125289)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-08-10 16:21:25 UTC (rev 125290)
@@ -1,3 +1,15 @@
+2012-08-10  Yong Li  <[email protected]>
+
+        [BlackBerry] GCActivityCallback should always schedule GC even allocated bytes is a small number
+        https://bugs.webkit.org/show_bug.cgi?id=93650
+
+        Reviewed by Rob Buis.
+
+        Even a small number of allocated JS objects could hold expensive resources.
+
+        * runtime/GCActivityCallbackBlackBerry.cpp:
+        (JSC::DefaultGCActivityCallback::didAllocate):
+
 2012-08-09  Yong Li  <[email protected]>
 
         [QNX] Implement getCPUTime() for OS(QNX)

Modified: trunk/Source/_javascript_Core/runtime/GCActivityCallbackBlackBerry.cpp (125289 => 125290)


--- trunk/Source/_javascript_Core/runtime/GCActivityCallbackBlackBerry.cpp	2012-08-10 16:15:59 UTC (rev 125289)
+++ trunk/Source/_javascript_Core/runtime/GCActivityCallbackBlackBerry.cpp	2012-08-10 16:21:25 UTC (rev 125290)
@@ -25,8 +25,6 @@
 
 namespace JSC {
 
-static const size_t bytesWorthGC = 4 * 1024 * 1024;
-
 DefaultGCActivityCallback::DefaultGCActivityCallback(Heap* heap)
     : GCActivityCallback(heap->globalData())
 {
@@ -40,7 +38,7 @@
 
 void DefaultGCActivityCallback::didAllocate(size_t bytesAllocated)
 {
-    if (bytesAllocated < bytesWorthGC || m_timer.started())
+    if (m_timer.started())
         return;
 
     // Try using ~5% CPU time.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to