Title: [125296] trunk
- Revision
- 125296
- Author
- [email protected]
- Date
- 2012-08-10 10:05:11 -0700 (Fri, 10 Aug 2012)
Log Message
[V8] Enable es5_readonly
https://bugs.webkit.org/show_bug.cgi?id=91031
Reviewed by Adam Barth.
This turns on the es5_readonly flag for V8. This makes V8 match the ES5 spec regarding
non writable properties on the prototype chain. JSC already behaves the right so this
just makes V8 behave the same.
Source/WebCore:
Updated test expectations.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):
LayoutTests:
* platform/chromium/media/network-no-source-const-shadow-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (125295 => 125296)
--- trunk/LayoutTests/ChangeLog 2012-08-10 17:03:15 UTC (rev 125295)
+++ trunk/LayoutTests/ChangeLog 2012-08-10 17:05:11 UTC (rev 125296)
@@ -1,3 +1,17 @@
+2012-08-10 Erik Arvidsson <[email protected]>
+
+ [V8] Enable es5_readonly
+ https://bugs.webkit.org/show_bug.cgi?id=91031
+
+ Reviewed by Adam Barth.
+
+ This turns on the es5_readonly flag for V8. This makes V8 match the ES5 spec regarding
+ non writable properties on the prototype chain. JSC already behaves the right so this
+ just makes V8 behave the same.
+
+
+ * platform/chromium/media/network-no-source-const-shadow-expected.txt: Added.
+
2012-08-10 Martin Leutelt <[email protected]>
[Qt] Dotted borders not drawn with rounded dots
Added: trunk/LayoutTests/platform/chromium/media/network-no-source-const-shadow-expected.txt (0 => 125296)
--- trunk/LayoutTests/platform/chromium/media/network-no-source-const-shadow-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/media/network-no-source-const-shadow-expected.txt 2012-08-10 17:05:11 UTC (rev 125296)
@@ -0,0 +1,15 @@
+Test that NETWORK_NO_SOURCE is immutable
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS HTMLMediaElement.NETWORK_NO_SOURCE is 3
+PASS HTMLMediaElement.prototype.NETWORK_NO_SOURCE is 3
+PASS element.NETWORK_NO_SOURCE is 3
+PASS HTMLMediaElement.NETWORK_NO_SOURCE is 3
+PASS HTMLAudioElement.prototype.NETWORK_NO_SOURCE is 3
+PASS element.NETWORK_NO_SOURCE is 3
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/Source/WebCore/ChangeLog (125295 => 125296)
--- trunk/Source/WebCore/ChangeLog 2012-08-10 17:03:15 UTC (rev 125295)
+++ trunk/Source/WebCore/ChangeLog 2012-08-10 17:05:11 UTC (rev 125296)
@@ -1,3 +1,21 @@
+2012-08-10 Erik Arvidsson <[email protected]>
+
+ [V8] Enable es5_readonly
+ https://bugs.webkit.org/show_bug.cgi?id=91031
+
+ Reviewed by Adam Barth.
+
+ This turns on the es5_readonly flag for V8. This makes V8 match the ES5 spec regarding
+ non writable properties on the prototype chain. JSC already behaves the right so this
+ just makes V8 behave the same.
+
+ Updated test expectations.
+
+ * bindings/v8/V8DOMWindowShell.cpp:
+ (WebCore::V8DOMWindowShell::initContextIfNeeded):
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::initIsolate):
+
2012-08-10 Kentaro Hara <[email protected]>
[V8] Introduce V8DOMConfiguration class and make batchConfigureXXX() methods static
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (125295 => 125296)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-10 17:03:15 UTC (rev 125295)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-08-10 17:05:11 UTC (rev 125296)
@@ -301,6 +301,10 @@
#endif
V8PerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
+ // FIXME: Remove the following 2 lines when V8 default has changed.
+ const char es5ReadonlyFlag[] = "--es5_readonly";
+ v8::V8::SetFlagsFromString(es5ReadonlyFlag, sizeof(es5ReadonlyFlag));
+
isV8Initialized = true;
}
Modified: trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp (125295 => 125296)
--- trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp 2012-08-10 17:03:15 UTC (rev 125295)
+++ trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp 2012-08-10 17:05:11 UTC (rev 125296)
@@ -122,6 +122,10 @@
v8::V8::SetGlobalGCPrologueCallback(&V8GCController::gcPrologue);
v8::V8::SetGlobalGCEpilogueCallback(&V8GCController::gcEpilogue);
+ // FIXME: Remove the following 2 lines when V8 default has changed.
+ const char es5ReadonlyFlag[] = "--es5_readonly";
+ v8::V8::SetFlagsFromString(es5ReadonlyFlag, sizeof(es5ReadonlyFlag));
+
v8::ResourceConstraints resource_constraints;
uint32_t here;
resource_constraints.set_stack_limit(&here - kWorkerMaxStackSize / sizeof(uint32_t*));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
