Title: [125326] trunk/Source/WebCore
- Revision
- 125326
- Author
- [email protected]
- Date
- 2012-08-10 14:09:08 -0700 (Fri, 10 Aug 2012)
Log Message
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Rubber-stamped by Ryosuke Niwa.
Fix Apple Win build, by avoiding to generate unreachable sections
of code in AccessibilityRenderObject::passwordFieldValue().
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::passwordFieldValue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125325 => 125326)
--- trunk/Source/WebCore/ChangeLog 2012-08-10 20:40:38 UTC (rev 125325)
+++ trunk/Source/WebCore/ChangeLog 2012-08-10 21:09:08 UTC (rev 125326)
@@ -1,3 +1,16 @@
+2012-08-10 Mario Sanchez Prada <[email protected]>
+
+ [GTK] Broken implementation of AtkText and AtkEditableText for password fields
+ https://bugs.webkit.org/show_bug.cgi?id=93621
+
+ Rubber-stamped by Ryosuke Niwa.
+
+ Fix Apple Win build, by avoiding to generate unreachable sections
+ of code in AccessibilityRenderObject::passwordFieldValue().
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::passwordFieldValue):
+
2012-08-10 Dana Jansens <[email protected]>
[chromium] Remove targetSurface pointer from CCRenderPass
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (125325 => 125326)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-08-10 20:40:38 UTC (rev 125325)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-08-10 21:09:08 UTC (rev 125326)
@@ -3932,11 +3932,7 @@
String AccessibilityRenderObject::passwordFieldValue() const
{
-#if !PLATFORM(GTK)
- // It seems only GTK is interested in this at the moment.
- return String();
-#endif
-
+#if PLATFORM(GTK)
ASSERT(isPasswordField());
// Look for the RenderText object in the RenderObject tree for this input field.
@@ -3949,6 +3945,10 @@
// Return the text that is actually being rendered in the input field.
return static_cast<RenderText*>(renderer)->textWithoutTranscoding();
+#else
+ // It seems only GTK is interested in this at the moment.
+ return String();
+#endif
}
ScrollableArea* AccessibilityRenderObject::getScrollableAreaIfScrollable() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
