Title: [125353] trunk/Source/WebCore
Revision
125353
Author
[email protected]
Date
2012-08-11 09:07:22 -0700 (Sat, 11 Aug 2012)

Log Message

Unreviewed.

Removing newly added assert in r125351 since it is exposing
legitimate layout bugs in few tests. We will re-add the assert
after fixing those bugs. Failures are tracked in webkit bug 93766.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFromTrackedRendererMaps):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (125352 => 125353)


--- trunk/Source/WebCore/ChangeLog	2012-08-11 13:26:27 UTC (rev 125352)
+++ trunk/Source/WebCore/ChangeLog	2012-08-11 16:07:22 UTC (rev 125353)
@@ -1,3 +1,14 @@
+2012-08-11  Abhishek Arya  <[email protected]>
+
+        Unreviewed. 
+
+        Removing newly added assert in r125351 since it is exposing
+        legitimate layout bugs in few tests. We will re-add the assert
+        after fixing those bugs. Failures are tracked in webkit bug 93766. 
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::removeFromTrackedRendererMaps):
+
 2012-08-11  Levi Weintraub  <[email protected]>
 
         Track block's positioned objects like percent-height descendants

Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (125352 => 125353)


--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-08-11 13:26:27 UTC (rev 125352)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-08-11 16:07:22 UTC (rev 125353)
@@ -3637,7 +3637,12 @@
     HashSet<RenderBlock*>::iterator end = containerSet->end();
     for (HashSet<RenderBlock*>::iterator it = containerSet->begin(); it != end; ++it) {
         RenderBlock* container = *it;
-        ASSERT(descendant->isDescendantOf(container));
+
+        // FIXME: Disabling this assert temporarily until we fix the layout
+        // bugs associated with positioned objects not properly cleared from
+        // their ancestor chain before being moved. See webkit bug 93766.
+        // ASSERT(descendant->isDescendantOf(container));
+
         TrackedRendererListHashSet* descendantSet = descendantsMap->get(container);
         ASSERT(descendantSet);
         if (!descendantSet)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to