Title: [125382] trunk/Source/WebKit/blackberry
Revision
125382
Author
[email protected]
Date
2012-08-12 16:01:20 -0700 (Sun, 12 Aug 2012)

Log Message

[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601

Patch by Arvid Nilsson <[email protected]> on 2012-08-12
Reviewed by Antonio Gomes.

Since the tap highlight is usually rather small, we can reimplement
GraphicsLayerClient::contentsVisible() to always return true in order
to keep all AC layer tiles cached all the time.

PR 189895

* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
(WebKit):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (125381 => 125382)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-08-12 22:59:27 UTC (rev 125381)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-08-12 23:01:20 UTC (rev 125382)
@@ -1,5 +1,24 @@
 2012-08-12  Arvid Nilsson  <[email protected]>
 
+        [BlackBerry] Tap highlight flashes checkerboard after pinch zoom
+        https://bugs.webkit.org/show_bug.cgi?id=93601
+
+        Reviewed by Antonio Gomes.
+
+        Since the tap highlight is usually rather small, we can reimplement
+        GraphicsLayerClient::contentsVisible() to always return true in order
+        to keep all AC layer tiles cached all the time.
+
+        PR 189895
+
+        * WebKitSupport/DefaultTapHighlight.cpp:
+        (BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
+        (WebKit):
+        * WebKitSupport/DefaultTapHighlight.h:
+        (DefaultTapHighlight):
+
+2012-08-12  Arvid Nilsson  <[email protected]>
+
         [BlackBerry] Tap highlight sometimes doesn't disappear
         https://bugs.webkit.org/show_bug.cgi?id=93711
 

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp (125381 => 125382)


--- trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp	2012-08-12 22:59:27 UTC (rev 125381)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp	2012-08-12 23:01:20 UTC (rev 125382)
@@ -158,6 +158,13 @@
     return m_page->showRepaintCounter(layer);
 }
 
+bool DefaultTapHighlight::contentsVisible(const GraphicsLayer*, const IntRect& contentRect) const
+{
+    // This layer is typically small enough that we can afford to cache all tiles and never
+    // risk checkerboarding.
+    return true;
+}
+
 } // namespace WebKit
 } // namespace BlackBerry
 

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h (125381 => 125382)


--- trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h	2012-08-12 22:59:27 UTC (rev 125381)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h	2012-08-12 23:01:20 UTC (rev 125382)
@@ -58,6 +58,7 @@
     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
     virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
     virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
+    virtual bool contentsVisible(const WebCore::GraphicsLayer*, const WebCore::IntRect& contentRect) const;
 
 private:
     DefaultTapHighlight(WebPagePrivate*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to