Title: [125394] trunk/Source/WebCore
- Revision
- 125394
- Author
- [email protected]
- Date
- 2012-08-13 00:19:14 -0700 (Mon, 13 Aug 2012)
Log Message
REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387
Patch by Peter Wang <[email protected]> on 2012-08-13
Reviewed by Pavel Feldman.
Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.
No new test case for this bug.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125393 => 125394)
--- trunk/Source/WebCore/ChangeLog 2012-08-13 06:55:49 UTC (rev 125393)
+++ trunk/Source/WebCore/ChangeLog 2012-08-13 07:19:14 UTC (rev 125394)
@@ -1,3 +1,19 @@
+2012-08-13 Peter Wang <[email protected]>
+
+ REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
+ https://bugs.webkit.org/show_bug.cgi?id=93387
+
+ Reviewed by Pavel Feldman.
+
+ Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
+ of "column" to make the behavior back to the time as JSC cannot provide "column" info.
+ Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.
+
+ No new test case for this bug.
+
+ * bindings/js/ScriptDebugServer.cpp:
+ (WebCore::ScriptDebugServer::hasBreakpoint):
+
2012-08-10 Kinuko Yasuda <[email protected]>
Support creating File object from FileSystem URL for files in FileSystem API
Modified: trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp (125393 => 125394)
--- trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2012-08-13 06:55:49 UTC (rev 125393)
+++ trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2012-08-13 07:19:14 UTC (rev 125394)
@@ -187,9 +187,8 @@
unsigned breaksCount = breaksVector.size();
unsigned i;
for (i = 0; i < breaksCount; i++) {
- int breakColumn = breaksVector.at(i).columnNumber;
int breakLine = breaksVector.at(i).lineNumber;
- if (lineNumber == breakLine && columnNumber == breakColumn) {
+ if (lineNumber == breakLine) {
hit = true;
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
