Title: [125407] trunk/Source/WebKit/gtk
- Revision
- 125407
- Author
- [email protected]
- Date
- 2012-08-13 03:35:48 -0700 (Mon, 13 Aug 2012)
Log Message
[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Patch by Martin Robinson <[email protected]> on 2012-08-13
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (125406 => 125407)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-08-13 10:16:09 UTC (rev 125406)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-08-13 10:35:48 UTC (rev 125407)
@@ -1,3 +1,17 @@
+2012-08-13 Martin Robinson <[email protected]>
+
+ [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
+ https://bugs.webkit.org/show_bug.cgi?id=93600
+
+ Reviewed by Xan Lopez.
+
+ Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
+ do not use a default signal handler. This means that the result of the signal defaults to FALSE,
+ which is the expected value to ensure that the delete interface is not shown.
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_class_init): Do not install a default signal handler.
+
2012-08-13 Mario Sanchez Prada <[email protected]>
[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (125406 => 125407)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-08-13 10:16:09 UTC (rev 125406)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-08-13 10:35:48 UTC (rev 125407)
@@ -2655,7 +2655,7 @@
webkit_web_view_signals[SHOULD_SHOW_DELETE_INTERFACE_FOR_ELEMENT] = g_signal_new("should-show-delete-interface-for-element",
G_TYPE_FROM_CLASS(webViewClass), static_cast<GSignalFlags>(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
- G_STRUCT_OFFSET(WebKitWebViewClass, should_allow_editing_action), g_signal_accumulator_first_wins, 0,
+ 0, g_signal_accumulator_first_wins, 0,
webkit_marshal_BOOLEAN__OBJECT, G_TYPE_BOOLEAN, 1, WEBKIT_TYPE_DOM_HTML_ELEMENT);
webkit_web_view_signals[SHOULD_CHANGE_SELECTED_RANGE] = g_signal_new("should-change-selected-range",
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
