Title: [125477] trunk/Source/WebCore
- Revision
- 125477
- Author
- [email protected]
- Date
- 2012-08-13 17:40:51 -0700 (Mon, 13 Aug 2012)
Log Message
[V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
https://bugs.webkit.org/show_bug.cgi?id=93803
Reviewed by Adam Barth.
In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
to V8PerIsolateData.cpp. This patch moves it.
No tests. No change in behavior.
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8PerIsolateData.cpp:
(WebCore):
(WebCore::V8PerIsolateData::visitExternalStrings):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125476 => 125477)
--- trunk/Source/WebCore/ChangeLog 2012-08-14 00:38:19 UTC (rev 125476)
+++ trunk/Source/WebCore/ChangeLog 2012-08-14 00:40:51 UTC (rev 125477)
@@ -1,3 +1,20 @@
+2012-08-13 Kentaro Hara <[email protected]>
+
+ [V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=93803
+
+ Reviewed by Adam Barth.
+
+ In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
+ to V8PerIsolateData.cpp. This patch moves it.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8Binding.cpp:
+ * bindings/v8/V8PerIsolateData.cpp:
+ (WebCore):
+ (WebCore::V8PerIsolateData::visitExternalStrings):
+
2012-08-13 Elliott Sprehn <[email protected]>
Expand list of supported languages for RenderQuote to match WHATWG spec
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (125476 => 125477)
--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-08-14 00:38:19 UTC (rev 125476)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-08-14 00:40:51 UTC (rev 125477)
@@ -52,27 +52,6 @@
namespace WebCore {
-#if ENABLE(INSPECTOR)
-void V8PerIsolateData::visitExternalStrings(ExternalStringVisitor* visitor)
-{
- v8::HandleScope handleScope;
- class VisitorImpl : public v8::ExternalResourceVisitor {
- public:
- VisitorImpl(ExternalStringVisitor* visitor) : m_visitor(visitor) { }
- virtual ~VisitorImpl() { }
- virtual void VisitExternalString(v8::Handle<v8::String> string)
- {
- WebCoreStringResource* resource = static_cast<WebCoreStringResource*>(string->GetExternalStringResource());
- if (resource)
- resource->visitStrings(m_visitor);
- }
- private:
- ExternalStringVisitor* m_visitor;
- } v8Visitor(visitor);
- v8::V8::VisitExternalResources(&v8Visitor);
-}
-#endif
-
static String v8NonStringValueToWebCoreString(v8::Handle<v8::Value> object)
{
ASSERT(!object->IsString());
Modified: trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp (125476 => 125477)
--- trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp 2012-08-14 00:38:19 UTC (rev 125476)
+++ trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp 2012-08-14 00:40:51 UTC (rev 125477)
@@ -84,4 +84,25 @@
info.addInstrumentedMember(m_domDataList[i]);
}
+#if ENABLE(INSPECTOR)
+void V8PerIsolateData::visitExternalStrings(ExternalStringVisitor* visitor)
+{
+ v8::HandleScope handleScope;
+ class VisitorImpl : public v8::ExternalResourceVisitor {
+ public:
+ VisitorImpl(ExternalStringVisitor* visitor) : m_visitor(visitor) { }
+ virtual ~VisitorImpl() { }
+ virtual void VisitExternalString(v8::Handle<v8::String> string)
+ {
+ WebCoreStringResource* resource = static_cast<WebCoreStringResource*>(string->GetExternalStringResource());
+ if (resource)
+ resource->visitStrings(m_visitor);
+ }
+ private:
+ ExternalStringVisitor* m_visitor;
+ } v8Visitor(visitor);
+ v8::V8::VisitExternalResources(&v8Visitor);
+}
+#endif
+
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
