Modified: trunk/Source/WebCore/ChangeLog (125482 => 125483)
--- trunk/Source/WebCore/ChangeLog 2012-08-14 00:51:31 UTC (rev 125482)
+++ trunk/Source/WebCore/ChangeLog 2012-08-14 00:53:23 UTC (rev 125483)
@@ -1,5 +1,30 @@
2012-08-13 Kentaro Hara <[email protected]>
+ [V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
+ https://bugs.webkit.org/show_bug.cgi?id=93839
+
+ Reviewed by Adam Barth.
+
+ For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
+ this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
+ ("WebCore" wouldn't be needed because it's clear from "DOMStringList".)
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (JSValueToNative):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::overloadedMethod6Callback):
+ (WebCore::TestObjV8Internal::overloadedMethod7Callback):
+ (WebCore::TestObjV8Internal::overloadedMethod9Callback):
+ (WebCore::TestObjV8Internal::stringArrayFunctionCallback):
+ * bindings/v8/V8Binding.cpp:
+ (WebCore::toDOMStringList):
+ * bindings/v8/V8Binding.h:
+ (WebCore):
+
+2012-08-13 Kentaro Hara <[email protected]>
+
[V8] Rename v8ValueToAtomicWebCoreString() to toWebCoreAtomicString()
https://bugs.webkit.org/show_bug.cgi?id=93824
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (125482 => 125483)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-08-14 00:51:31 UTC (rev 125482)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-08-14 00:53:23 UTC (rev 125483)
@@ -3767,9 +3767,9 @@
return "toInt64($value)" if $type eq "unsigned long long" or $type eq "long long";
return "static_cast<Range::CompareHow>($value->Int32Value())" if $type eq "CompareHow";
return "toWebCoreDate($value)" if $type eq "Date";
- return "v8ValueToWebCoreDOMStringList($value)" if $type eq "DOMStringList";
+ return "toDOMStringList($value)" if $type eq "DOMStringList";
# FIXME: Add proper support for T[], T[]? and sequence<T>.
- return "v8ValueToWebCoreDOMStringList($value)" if $type eq "DOMString[]";
+ return "toDOMStringList($value)" if $type eq "DOMString[]";
if ($type eq "DOMString" or $type eq "DOMUserData") {
return $value;
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (125482 => 125483)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-08-14 00:51:31 UTC (rev 125482)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-08-14 00:53:23 UTC (rev 125483)
@@ -1605,7 +1605,7 @@
if (args.Length() < 1)
return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());
TestObj* imp = V8TestObj::toNative(args.Holder());
- EXCEPTION_BLOCK(RefPtr<DOMStringList>, listArg, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+ EXCEPTION_BLOCK(RefPtr<DOMStringList>, listArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
imp->overloadedMethod(listArg);
return v8Undefined();
}
@@ -1616,7 +1616,7 @@
if (args.Length() < 1)
return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());
TestObj* imp = V8TestObj::toNative(args.Holder());
- EXCEPTION_BLOCK(RefPtr<DOMStringList>, arrayArg, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+ EXCEPTION_BLOCK(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
imp->overloadedMethod(arrayArg);
return v8Undefined();
}
@@ -1638,7 +1638,7 @@
if (args.Length() < 1)
return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());
TestObj* imp = V8TestObj::toNative(args.Holder());
- EXCEPTION_BLOCK(RefPtr<DOMStringList>, arrayArg, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+ EXCEPTION_BLOCK(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
imp->overloadedMethod(arrayArg);
return v8Undefined();
}
@@ -1809,7 +1809,7 @@
TestObj* imp = V8TestObj::toNative(args.Holder());
ExceptionCode ec = 0;
{
- EXCEPTION_BLOCK(RefPtr<DOMStringList>, values, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+ EXCEPTION_BLOCK(RefPtr<DOMStringList>, values, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
RefPtr<DOMStringList> result = imp->stringArrayFunction(values, ec);
if (UNLIKELY(ec))
goto fail;
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (125482 => 125483)
--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-08-14 00:51:31 UTC (rev 125482)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp 2012-08-14 00:53:23 UTC (rev 125483)
@@ -334,7 +334,7 @@
info.addHashMap(m_stringCache);
}
-PassRefPtr<DOMStringList> v8ValueToWebCoreDOMStringList(v8::Handle<v8::Value> value)
+PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value)
{
v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(value));
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (125482 => 125483)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-08-14 00:51:31 UTC (rev 125482)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-08-14 00:53:23 UTC (rev 125483)
@@ -388,7 +388,7 @@
String int32ToWebCoreString(int value);
- PassRefPtr<DOMStringList> v8ValueToWebCoreDOMStringList(v8::Handle<v8::Value>);
+ PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value>);
class V8ParameterBase {
public:
