Title: [125492] trunk/Source/WebCore
Revision
125492
Author
[email protected]
Date
2012-08-13 18:34:06 -0700 (Mon, 13 Aug 2012)

Log Message

[V8] Remove unused methods from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93836

Reviewed by Adam Barth.

enableStringImplCache() and v8UndetectableString() are not used by anybody.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (125491 => 125492)


--- trunk/Source/WebCore/ChangeLog	2012-08-14 01:32:08 UTC (rev 125491)
+++ trunk/Source/WebCore/ChangeLog	2012-08-14 01:34:06 UTC (rev 125492)
@@ -1,5 +1,18 @@
 2012-08-13  Kentaro Hara  <[email protected]>
 
+        [V8] Remove unused methods from V8Binding.h
+        https://bugs.webkit.org/show_bug.cgi?id=93836
+
+        Reviewed by Adam Barth.
+
+        enableStringImplCache() and v8UndetectableString() are not used by anybody.
+
+        No tests. No change in behavior.
+
+        * bindings/v8/V8Binding.h:
+
+2012-08-13  Kentaro Hara  <[email protected]>
+
         [V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
         https://bugs.webkit.org/show_bug.cgi?id=93834
 

Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (125491 => 125492)


--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-08-14 01:32:08 UTC (rev 125491)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-08-14 01:34:06 UTC (rev 125492)
@@ -257,11 +257,6 @@
         return v8Value;
     }
 
-    // Enables caching v8 wrappers created for WTF::StringImpl.  Currently this cache requires
-    // all the calls (both to convert WTF::String to v8::String and to GC the handle)
-    // to be performed on the main thread.
-    void enableStringImplCache();
-
     // Convert a value to a 32-bit integer.  The conversion fails if the
     // value cannot be converted to an integer or converts to nan or to an infinity.
     int toInt32(v8::Handle<v8::Value> value, bool& ok);
@@ -351,11 +346,6 @@
         return value->IsNull() ? AtomicString() : toWebCoreAtomicString(value);
     }
 
-    inline v8::Handle<v8::String> v8UndetectableString(const String& str)
-    {
-        return v8::String::NewUndetectable(fromWebCoreString(str), str.length());
-    }
-
     inline v8::Handle<v8::Value> v8StringOrNull(const String& str, v8::Isolate* isolate = 0)
     {
         return str.isNull() ? v8::Handle<v8::Value>(v8::Null()) : v8::Handle<v8::Value>(v8String(str, isolate));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to