Title: [125515] trunk/Tools
- Revision
- 125515
- Author
- [email protected]
- Date
- 2012-08-14 00:31:34 -0700 (Tue, 14 Aug 2012)
Log Message
[GTK] String returned by g_path_get_dirname() must be freed
https://bugs.webkit.org/show_bug.cgi?id=93885
Patch by Sudarsana Nagineni <[email protected]> on 2012-08-14
Reviewed by Philippe Normand.
Fix a memory leak in GTK's DRT code.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Free the string returned by g_path_get_dirname().
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (125514 => 125515)
--- trunk/Tools/ChangeLog 2012-08-14 07:25:47 UTC (rev 125514)
+++ trunk/Tools/ChangeLog 2012-08-14 07:31:34 UTC (rev 125515)
@@ -1,3 +1,15 @@
+2012-08-14 Sudarsana Nagineni <[email protected]>
+
+ [GTK] String returned by g_path_get_dirname() must be freed
+ https://bugs.webkit.org/show_bug.cgi?id=93885
+
+ Reviewed by Philippe Normand.
+
+ Fix a memory leak in GTK's DRT code.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (pathFromSoupURI): Free the string returned by g_path_get_dirname().
+
2012-08-14 Zan Dobersek <[email protected]>
Unreviewed GTK build fix after r125508.
Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (125514 => 125515)
--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-08-14 07:25:47 UTC (rev 125514)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-08-14 07:31:34 UTC (rev 125515)
@@ -1126,7 +1126,8 @@
return CString(uriString.get());
}
- GOwnPtr<gchar> pathDirname(g_path_get_basename(g_path_get_dirname(uri->path)));
+ GOwnPtr<gchar> parentPath(g_path_get_dirname(uri->path));
+ GOwnPtr<gchar> pathDirname(g_path_get_basename(parentPath.get()));
GOwnPtr<gchar> pathBasename(g_path_get_basename(uri->path));
GOwnPtr<gchar> urlPath(g_strdup_printf("%s/%s", pathDirname.get(), pathBasename.get()));
return CString(urlPath.get());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
