Title: [125668] trunk/Source/WebCore
Revision
125668
Author
[email protected]
Date
2012-08-15 05:06:45 -0700 (Wed, 15 Aug 2012)

Log Message

Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (125667 => 125668)


--- trunk/Source/WebCore/ChangeLog	2012-08-15 11:55:51 UTC (rev 125667)
+++ trunk/Source/WebCore/ChangeLog	2012-08-15 12:06:45 UTC (rev 125668)
@@ -1,3 +1,16 @@
+2012-08-15  Vsevolod Vlasov  <[email protected]>
+
+        Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
+        https://bugs.webkit.org/show_bug.cgi?id=94074
+
+        Reviewed by Pavel Feldman.
+
+        Added dirty flag check when saving uiSourceCode to save working copy in this case.
+
+        * inspector/front-end/HandlerRegistry.js:
+        (WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
+        (WebInspector.HandlerRegistry.prototype.appendApplicableItems):
+
 2012-08-15  Thiago Marcos P. Santos  <[email protected]>
 
         Relative units are not set when the canvas has not parent

Modified: trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js (125667 => 125668)


--- trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-08-15 11:55:51 UTC (rev 125667)
+++ trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-08-15 12:06:45 UTC (rev 125668)
@@ -127,6 +127,13 @@
 
         function save(forceSaveAs)
         {
+            if (contentProvider instanceof WebInspector.UISourceCode) {
+                var uiSourceCode = /** @type {WebInspector.UISourceCode} */ contentProvider;
+                if (uiSourceCode.isDirty()) {
+                    doSave(forceSaveAs, uiSourceCode.workingCopy());
+                    return;
+                }
+            }
             contentProvider.requestContent(doSave.bind(this, forceSaveAs));
         }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to