Title: [125676] trunk/Source/WebKit/blackberry
- Revision
- 125676
- Author
- [email protected]
- Date
- 2012-08-15 08:50:04 -0700 (Wed, 15 Aug 2012)
Log Message
[BlackBerry] Check for valid field focus before processing a spellcheck request
https://bugs.webkit.org/show_bug.cgi?id=94115
Patch by Nima Ghanavatian <[email protected]> on 2012-08-15
Reviewed by Rob Buis.
PR192891
Checking for valid field focus before processing the spellcheck
request.
Internally reviewed by Mike Fenton.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (125675 => 125676)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-15 15:46:47 UTC (rev 125675)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-15 15:50:04 UTC (rev 125676)
@@ -1,3 +1,19 @@
+2012-08-15 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Check for valid field focus before processing a spellcheck request
+ https://bugs.webkit.org/show_bug.cgi?id=94115
+
+ Reviewed by Rob Buis.
+
+ PR192891
+ Checking for valid field focus before processing the spellcheck
+ request.
+
+ Internally reviewed by Mike Fenton.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
+
2012-08-14 Adam Barth <[email protected]>
Delete Frame::domWindow() and Frame::existingDOMWindow()
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (125675 => 125676)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-08-15 15:46:47 UTC (rev 125675)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-08-15 15:50:04 UTC (rev 125676)
@@ -535,6 +535,11 @@
int32_t sequenceId = request->sequence();
+ if (!isActiveTextEdit()) {
+ spellCheckingRequestCancelled(sequenceId, true /* isSequenceId */);
+ return;
+ }
+
// Check if field explicitly asked for spellchecking.
if (DOMSupport::elementSupportsSpellCheck(m_currentFocusElement.get()) != DOMSupport::On) {
spellCheckingRequestCancelled(sequenceId, true /* isSequenceId */);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes