Title: [125683] trunk/Tools
Revision
125683
Author
[email protected]
Date
2012-08-15 10:59:08 -0700 (Wed, 15 Aug 2012)

Log Message

Fix a warning in TestWebKitAPI's MediaTime test-suite
https://bugs.webkit.org/show_bug.cgi?id=94096

Reviewed by Adam Barth.

This warning is visible when building the file with certain GCC versions,
including the one used by Chromium for Android. The warning is visible in
the cr-android build bot output:

MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90

* TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (125682 => 125683)


--- trunk/Tools/ChangeLog	2012-08-15 16:58:02 UTC (rev 125682)
+++ trunk/Tools/ChangeLog	2012-08-15 17:59:08 UTC (rev 125683)
@@ -1,3 +1,19 @@
+2012-08-15  Peter Beverloo  <[email protected]>
+
+        Fix a warning in TestWebKitAPI's MediaTime test-suite
+        https://bugs.webkit.org/show_bug.cgi?id=94096
+
+        Reviewed by Adam Barth.
+
+        This warning is visible when building the file with certain GCC versions,
+        including the one used by Chromium for Android. The warning is visible in
+        the cr-android build bot output:
+
+        MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
+
+        * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
+        (TestWebKitAPI::TEST):
+
 2012-08-15  Kevin Funk  <[email protected]>
 
         Fix the 'git log' call in VCSUtils.pm for Windows

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp (125682 => 125683)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp	2012-08-15 16:58:02 UTC (rev 125682)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp	2012-08-15 17:59:08 UTC (rev 125683)
@@ -149,7 +149,7 @@
     EXPECT_EQ(MediaTime(3, 2).toDouble(), 1.5);
     EXPECT_EQ(MediaTime(1, 1 << 16).toFloat(), 1 / pow(2.0f, 16.0f));
     EXPECT_EQ(MediaTime(1, 1 << 30).toDouble(), 1 / pow(2.0, 30.0));
-    EXPECT_EQ(MediaTime::createWithDouble(M_PI, 1 << 30), MediaTime(3373259426, 1 << 30));
+    EXPECT_EQ(MediaTime::createWithDouble(M_PI, 1 << 30), MediaTime(3373259426U, 1 << 30));
     EXPECT_EQ(MediaTime::createWithFloat(INFINITY), MediaTime::positiveInfiniteTime());
     EXPECT_EQ(MediaTime::createWithFloat(-INFINITY), MediaTime::negativeInfiniteTime());
     EXPECT_EQ(MediaTime::createWithFloat(NAN), MediaTime::invalidTime());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to