Title: [125696] trunk/Source/WebKit/chromium
- Revision
- 125696
- Author
- [email protected]
- Date
- 2012-08-15 12:36:46 -0700 (Wed, 15 Aug 2012)
Log Message
[chromium] IndexedDB: Delete unused WebKit API cursor accessors
https://bugs.webkit.org/show_bug.cgi?id=94134
Reviewed by Adam Barth.
Last bit of refactor work from http://webkit.org/b/92278 that ships the
cursor key/primaryKey/value to the front end via success messages, eliminating
the need for these accessors and the old success messages.
* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125695 => 125696)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-15 19:33:37 UTC (rev 125695)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-15 19:36:46 UTC (rev 125696)
@@ -1,3 +1,17 @@
+2012-08-15 Joshua Bell <[email protected]>
+
+ [chromium] IndexedDB: Delete unused WebKit API cursor accessors
+ https://bugs.webkit.org/show_bug.cgi?id=94134
+
+ Reviewed by Adam Barth.
+
+ Last bit of refactor work from http://webkit.org/b/92278 that ships the
+ cursor key/primaryKey/value to the front end via success messages, eliminating
+ the need for these accessors and the old success messages.
+
+ * public/WebIDBCallbacks.h:
+ * public/WebIDBCursor.h:
+
2012-08-15 Anna Cavender <[email protected]>
Add the timestampOffset attribute to SourceBuffer.
Modified: trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h (125695 => 125696)
--- trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2012-08-15 19:33:37 UTC (rev 125695)
+++ trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2012-08-15 19:36:46 UTC (rev 125696)
@@ -50,16 +50,12 @@
// For the rest, pass ownership to the callee via a pointer.
virtual void onError(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebDOMStringList&) { WEBKIT_ASSERT_NOT_REACHED(); }
- // FIXME: Remove this no-op method when callers are updated.
- virtual void onSuccess(WebIDBCursor*) { }
virtual void onSuccess(WebIDBCursor*, const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebIDBKey&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBTransaction*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebSerializedScriptValue&, const WebIDBKey&, const WebIDBKeyPath&) { WEBKIT_ASSERT_NOT_REACHED(); }
- // FIXME: Remove this no-op method when callers are updated.
- virtual void onSuccessWithContinuation() { }
virtual void onSuccess(const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onBlocked(long long oldVersion) { WEBKIT_ASSERT_NOT_REACHED(); }
Modified: trunk/Source/WebKit/chromium/public/WebIDBCursor.h (125695 => 125696)
--- trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2012-08-15 19:33:37 UTC (rev 125695)
+++ trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2012-08-15 19:36:46 UTC (rev 125696)
@@ -47,23 +47,6 @@
PrevNoDuplicate = 3,
};
- // FIXME: Remove these methods when callers are updated.
- virtual WebIDBKey key() const
- {
- WEBKIT_ASSERT_NOT_REACHED();
- return WebIDBKey::createInvalid();
- }
- virtual WebIDBKey primaryKey() const
- {
- WEBKIT_ASSERT_NOT_REACHED();
- return WebIDBKey::createInvalid();
- }
- virtual WebSerializedScriptValue value() const
- {
- WEBKIT_ASSERT_NOT_REACHED();
- return WebSerializedScriptValue();
- }
-
virtual void advance(unsigned long, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void continueFunction(const WebIDBKey&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void deleteFunction(WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
