Title: [125744] trunk
Revision
125744
Author
[email protected]
Date
2012-08-15 21:51:14 -0700 (Wed, 15 Aug 2012)

Log Message

[Shadow] Stop 'load' and 'error' events at shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=93425

Reviewed by Dimitri Glazkov.

Source/WebCore:

The shadow DOM spec has added these events as 'always-be-stopped' events at shadow boundaries.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):

LayoutTests:

* fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
* fast/dom/shadow/events-stopped-at-shadow-boundary.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (125743 => 125744)


--- trunk/LayoutTests/ChangeLog	2012-08-16 04:21:53 UTC (rev 125743)
+++ trunk/LayoutTests/ChangeLog	2012-08-16 04:51:14 UTC (rev 125744)
@@ -1,3 +1,13 @@
+2012-08-15  Hayato Ito  <[email protected]>
+
+        [Shadow] Stop 'load' and 'error' events at shadow boundaries
+        https://bugs.webkit.org/show_bug.cgi?id=93425
+
+        Reviewed by Dimitri Glazkov.
+
+        * fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
+        * fast/dom/shadow/events-stopped-at-shadow-boundary.html:
+
 2012-08-15  Yoshifumi Inoue  <[email protected]>
 
         [Tests] Copy to fast/forms/resources/common-wheel-event.js from fast/forms/number/number-wheel-event.html

Modified: trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt (125743 => 125744)


--- trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt	2012-08-16 04:21:53 UTC (rev 125743)
+++ trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt	2012-08-16 04:51:14 UTC (rev 125744)
@@ -33,6 +33,14 @@
      @target (target: target)
      @parent-of-target (target: target)
 
+  load
+     @target (target: target)
+     @parent-of-target (target: target)
+
+  error
+     @target (target: target)
+     @parent-of-target (target: target)
+
   click
      @target (target: target)
      @parent-of-target (target: target)

Modified: trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html (125743 => 125744)


--- trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html	2012-08-16 04:21:53 UTC (rev 125743)
+++ trunk/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html	2012-08-16 04:51:14 UTC (rev 125744)
@@ -51,7 +51,7 @@
 
 debug('Other events than "click" should be stopped at shadow boundary.  A "click" is added for the purpose of comparing results.'); 
 
-var events = ['abort', 'select', 'change', 'reset', 'resize', 'scroll', 'selectstart', 'click'];
+var events = ['abort', 'select', 'change', 'reset', 'resize', 'scroll', 'selectstart', 'load', 'error', 'click'];
 
 function addEventListeners(nodes)
 {

Modified: trunk/Source/WebCore/ChangeLog (125743 => 125744)


--- trunk/Source/WebCore/ChangeLog	2012-08-16 04:21:53 UTC (rev 125743)
+++ trunk/Source/WebCore/ChangeLog	2012-08-16 04:51:14 UTC (rev 125744)
@@ -1,3 +1,18 @@
+2012-08-15  Hayato Ito  <[email protected]>
+
+        [Shadow] Stop 'load' and 'error' events at shadow boundaries
+        https://bugs.webkit.org/show_bug.cgi?id=93425
+
+        Reviewed by Dimitri Glazkov.
+
+        The shadow DOM spec has added these events as 'always-be-stopped' events at shadow boundaries.
+        http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped
+
+        Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html
+
+        * dom/EventDispatcher.cpp:
+        (WebCore::EventDispatcher::determineDispatchBehavior):
+
 2012-08-15  Kent Tamura  <[email protected]>
 
         Calendar Picker: Localize numbers in a calendar picker

Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (125743 => 125744)


--- trunk/Source/WebCore/dom/EventDispatcher.cpp	2012-08-16 04:21:53 UTC (rev 125743)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp	2012-08-16 04:51:14 UTC (rev 125744)
@@ -395,6 +395,8 @@
     if (inTheSameScope(shadowRoot, target)
         && (eventType == eventNames().abortEvent
             || eventType == eventNames().changeEvent
+            || eventType == eventNames().errorEvent
+            || eventType == eventNames().loadEvent
             || eventType == eventNames().resetEvent
             || eventType == eventNames().resizeEvent
             || eventType == eventNames().scrollEvent
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to