Title: [125764] trunk/Source/WebKit/chromium
Revision
125764
Author
[email protected]
Date
2012-08-16 02:28:20 -0700 (Thu, 16 Aug 2012)

Log Message

DOMWindowPagePopup needs to be installed before loading the html inside the page popup
https://bugs.webkit.org/show_bug.cgi?id=94193

Reviewed by Kent Tamura.

We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (125763 => 125764)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-16 09:18:34 UTC (rev 125763)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-16 09:28:20 UTC (rev 125764)
@@ -1,3 +1,15 @@
+2012-08-16  Keishi Hattori  <[email protected]>
+
+        DOMWindowPagePopup needs to be installed before loading the html inside the page popup
+        https://bugs.webkit.org/show_bug.cgi?id=94193
+
+        Reviewed by Kent Tamura.
+
+        We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.
+
+        * src/WebPagePopupImpl.cpp:
+        (WebKit::WebPagePopupImpl::initPage):
+
 2012-08-16  Marja Hölttä  <[email protected]>
 
         WebHistoryItem: Enable reading selected file names from document state

Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (125763 => 125764)


--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp	2012-08-16 09:18:34 UTC (rev 125763)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp	2012-08-16 09:28:20 UTC (rev 125764)
@@ -191,14 +191,14 @@
     frame->view()->resize(m_popupClient->contentSize());
     frame->view()->setTransparent(false);
 
+    DOMWindowPagePopup::install(frame->document()->domWindow(), m_popupClient);
+
     DocumentWriter* writer = frame->loader()->activeDocumentLoader()->writer();
     writer->setMIMEType("text/html");
     writer->setEncoding("UTF-8", false);
     writer->begin();
     m_popupClient->writeDocument(*writer);
     writer->end();
-
-    DOMWindowPagePopup::install(frame->document()->domWindow(), m_popupClient);
     return true;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to