Title: [125789] trunk/LayoutTests
- Revision
- 125789
- Author
- [email protected]
- Date
- 2012-08-16 10:20:24 -0700 (Thu, 16 Aug 2012)
Log Message
Make compositing/layer-creation/overflow-scroll-overlap non-flaky
https://bugs.webkit.org/show_bug.cgi?id=94162
Reviewed by James Robinson.
This test has been failing flakily in Chromium with the scrollbar
layer sometimes being composited and sometimes not. This is likely due
to the video flakily being accelerated depending on whether it has
loaded or not.
Fix this test by making it always have a vertical scrollbar and remove
the video with an always-composited div.
* compositing/layer-creation/overflow-scroll-overlap-expected.txt:
* compositing/layer-creation/overflow-scroll-overlap.html:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (125788 => 125789)
--- trunk/LayoutTests/ChangeLog 2012-08-16 17:16:06 UTC (rev 125788)
+++ trunk/LayoutTests/ChangeLog 2012-08-16 17:20:24 UTC (rev 125789)
@@ -1,3 +1,23 @@
+2012-08-16 Adrienne Walker <[email protected]>
+
+ Make compositing/layer-creation/overflow-scroll-overlap non-flaky
+ https://bugs.webkit.org/show_bug.cgi?id=94162
+
+ Reviewed by James Robinson.
+
+ This test has been failing flakily in Chromium with the scrollbar
+ layer sometimes being composited and sometimes not. This is likely due
+ to the video flakily being accelerated depending on whether it has
+ loaded or not.
+
+ Fix this test by making it always have a vertical scrollbar and remove
+ the video with an always-composited div.
+
+ * compositing/layer-creation/overflow-scroll-overlap-expected.txt:
+ * compositing/layer-creation/overflow-scroll-overlap.html:
+ * platform/chromium/TestExpectations:
+ * platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
+
2012-08-16 Zan Dobersek <[email protected]>
Unreviewed GTK gardening.
Modified: trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt (125788 => 125789)
--- trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt 2012-08-16 17:16:06 UTC (rev 125788)
+++ trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt 2012-08-16 17:20:24 UTC (rev 125789)
@@ -1,4 +1,4 @@
- (GraphicsLayer
+(GraphicsLayer
(bounds 800.00 600.00)
(children 1
(GraphicsLayer
@@ -7,12 +7,18 @@
(GraphicsLayer
(position 8.00 8.00)
(bounds 30.00 30.00)
- (opacity 0.00)
)
(GraphicsLayer
(position 20.00 20.00)
(bounds 306.00 206.00)
(drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (position 288.00 3.00)
+ (bounds 15.00 200.00)
+ (drawsContent 1)
+ )
+ )
)
(GraphicsLayer
(position 23.00 23.00)
Modified: trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html (125788 => 125789)
--- trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html 2012-08-16 17:16:06 UTC (rev 125788)
+++ trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html 2012-08-16 17:20:24 UTC (rev 125789)
@@ -4,17 +4,17 @@
<head>
<style type="text/css" media="screen">
- video {
+ .composited {
height: 30px;
width: 30px;
- opacity: 0; /* Avoid issues in pixel test */
+ -webkit-transform:translateZ(0);
}
.overflow {
position: absolute;
top: 20px;
left: 20px;
- overflow: auto;
+ overflow-y: scroll;
height: 200px;
width: 300px;
border: solid;
@@ -60,7 +60,7 @@
</head>
<body>
- <video src="" height="20" width="20"></video>
+ <div class="composited"></div>
<div id="scroller" class="overflow">
<div class="box" style="width: 200px";></div>
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125788 => 125789)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-16 17:16:06 UTC (rev 125788)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-16 17:20:24 UTC (rev 125789)
@@ -3287,8 +3287,6 @@
BUGWK88131 DEBUG : fast/dom/HTMLMeterElement/meter-element-crash.html = PASS TEXT
-BUGWK67116 DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = PASS TEXT
-
BUGWK88593 : fast/table/multiple-captions-display.xhtml = PASS IMAGE IMAGE+TEXT
BUGWK88900 MAC : http/tests/misc/embed-image-load-outlives-gc-without-crashing.html = TEXT
Deleted: trunk/LayoutTests/platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt (125788 => 125789)
--- trunk/LayoutTests/platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt 2012-08-16 17:16:06 UTC (rev 125788)
+++ trunk/LayoutTests/platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt 2012-08-16 17:20:24 UTC (rev 125789)
@@ -1,39 +0,0 @@
- (GraphicsLayer
- (bounds 800.00 600.00)
- (children 1
- (GraphicsLayer
- (bounds 800.00 600.00)
- (children 3
- (GraphicsLayer
- (position 8.00 8.00)
- (bounds 30.00 30.00)
- (opacity 0.00)
- )
- (GraphicsLayer
- (position 20.00 20.00)
- (bounds 306.00 206.00)
- (drawsContent 1)
- (children 1
- (GraphicsLayer
- (position 288.00 3.00)
- (bounds 15.00 200.00)
- (drawsContent 1)
- )
- )
- )
- (GraphicsLayer
- (position 23.00 23.00)
- (bounds 285.00 200.00)
- (children 1
- (GraphicsLayer
- (position 20.00 45.00)
- (bounds 210.00 100.00)
- (drawsContent 1)
- )
- )
- )
- )
- )
- )
-)
-
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
