Title: [125792] trunk
Revision
125792
Author
[email protected]
Date
2012-08-16 10:45:15 -0700 (Thu, 16 Aug 2012)

Log Message

[Chromium] Pass the --strip-binary argument to the apk test generator
https://bugs.webkit.org/show_bug.cgi?id=94224

Reviewed by Adam Barth.

The native test generator currently relies on the $STRIP environment
variable to be available, which it shouldn't do. Instead, pass it as an
argument to the script. The $STRIP variable is being deprecated.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (125791 => 125792)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-16 17:33:29 UTC (rev 125791)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-16 17:45:15 UTC (rev 125792)
@@ -1,3 +1,16 @@
+2012-08-16  Peter Beverloo  <[email protected]>
+
+        [Chromium] Pass the --strip-binary argument to the apk test generator
+        https://bugs.webkit.org/show_bug.cgi?id=94224
+
+        Reviewed by Adam Barth.
+
+        The native test generator currently relies on the $STRIP environment
+        variable to be available, which it shouldn't do. Instead, pass it as an
+        argument to the script. The $STRIP variable is being deprecated.
+
+        * WebKitUnitTests.gyp:
+
 2012-08-16  James Robinson  <[email protected]>
 
         [chromium] Remove alwaysReserveTextures code - it doesn't do anything

Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125791 => 125792)


--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp	2012-08-16 17:33:29 UTC (rev 125791)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp	2012-08-16 17:45:15 UTC (rev 125792)
@@ -178,6 +178,7 @@
                         '"<@(input_jars_paths)"',
                         '--output',
                         '<(PRODUCT_DIR)/webkit_unit_tests_apk',
+                        '--strip-binary=<(android_strip)',
                         '--ant-args',
                         '-DANDROID_SDK=<(android_sdk)',
                         '--ant-args',

Modified: trunk/Tools/ChangeLog (125791 => 125792)


--- trunk/Tools/ChangeLog	2012-08-16 17:33:29 UTC (rev 125791)
+++ trunk/Tools/ChangeLog	2012-08-16 17:45:15 UTC (rev 125792)
@@ -1,3 +1,17 @@
+2012-08-16  Peter Beverloo  <[email protected]>
+
+        [Chromium] Pass the --strip-binary argument to the apk test generator
+        https://bugs.webkit.org/show_bug.cgi?id=94224
+
+        Reviewed by Adam Barth.
+
+        The native test generator currently relies on the $STRIP environment
+        variable to be available, which it shouldn't do. Instead, pass it as an
+        argument to the script. The $STRIP variable is being deprecated.
+
+        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+        * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
+
 2012-08-16  Xiaobo Wang  <[email protected]>
 
         [BlackBerry] Update format of JS console message to keep consistent with other ports.

Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (125791 => 125792)


--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-08-16 17:33:29 UTC (rev 125791)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-08-16 17:45:15 UTC (rev 125792)
@@ -495,6 +495,7 @@
                         '"<@(input_jars_paths)"',
                         '--output',
                         '<(PRODUCT_DIR)/DumpRenderTree_apk',
+                        '--strip-binary=<(android_strip)',
                         '--ant-args',
                         '-DANDROID_SDK=<(android_sdk)',
                         '--ant-args',

Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp (125791 => 125792)


--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp	2012-08-16 17:33:29 UTC (rev 125791)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp	2012-08-16 17:45:15 UTC (rev 125792)
@@ -138,6 +138,7 @@
                         '"<@(input_jars_paths)"',
                         '--output',
                         '<(PRODUCT_DIR)/TestWebKitAPI_apk',
+                        '--strip-binary=<(android_strip)',
                         '--ant-args',
                         '-DANDROID_SDK=<(android_sdk)',
                         '--ant-args',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to