Title: [125872] trunk/Source/WebKit2
- Revision
- 125872
- Author
- [email protected]
- Date
- 2012-08-17 02:25:13 -0700 (Fri, 17 Aug 2012)
Log Message
[EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
https://bugs.webkit.org/show_bug.cgi?id=94308
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
The reason is that loadClient.didChangeBackForwardList callback is invoked with zero
arguments which is valid case while page back-forward navigation and means basically
that the back-froward list has changed but items were not added or deleted.
* UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_changed):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (125871 => 125872)
--- trunk/Source/WebKit2/ChangeLog 2012-08-17 09:08:56 UTC (rev 125871)
+++ trunk/Source/WebKit2/ChangeLog 2012-08-17 09:25:13 UTC (rev 125872)
@@ -1,3 +1,17 @@
+2012-08-17 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
+ https://bugs.webkit.org/show_bug.cgi?id=94308
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ The reason is that loadClient.didChangeBackForwardList callback is invoked with zero
+ arguments which is valid case while page back-forward navigation and means basically
+ that the back-froward list has changed but items were not added or deleted.
+
+ * UIProcess/API/efl/ewk_back_forward_list.cpp:
+ (ewk_back_forward_list_changed):
+
2012-08-16 Lauro Neto <[email protected]>
[Qt] Failure to build with --no-inspector
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp (125871 => 125872)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp 2012-08-17 09:08:56 UTC (rev 125871)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp 2012-08-17 09:25:13 UTC (rev 125872)
@@ -128,7 +128,8 @@
*/
void ewk_back_forward_list_changed(Ewk_Back_Forward_List* list, WKBackForwardListItemRef wkAddedItem, WKArrayRef wkRemovedItems)
{
- addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache.
+ if (wkAddedItem) // Checking also here to avoid EINA_SAFETY_ON_NULL_RETURN_VAL warnings.
+ addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache.
const size_t removedItemsSize = wkRemovedItems ? WKArrayGetSize(wkRemovedItems) : 0;
for (size_t i = 0; i < removedItemsSize; ++i) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
