Title: [125881] trunk/Source/WebCore
- Revision
- 125881
- Author
- [email protected]
- Date
- 2012-08-17 05:06:27 -0700 (Fri, 17 Aug 2012)
Log Message
Web Inspector: decouple extension server from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=94322
Reviewed by Pavel Feldman.
- relay WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged received in ElementsPanel on WebInspector.notifications;
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
* inspector/front-end/ExtensionServer.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125880 => 125881)
--- trunk/Source/WebCore/ChangeLog 2012-08-17 11:42:08 UTC (rev 125880)
+++ trunk/Source/WebCore/ChangeLog 2012-08-17 12:06:27 UTC (rev 125881)
@@ -1,3 +1,16 @@
+2012-08-17 Andrey Kosyakov <[email protected]>
+
+ Web Inspector: decouple extension server from the Elements panel
+ https://bugs.webkit.org/show_bug.cgi?id=94322
+
+ Reviewed by Pavel Feldman.
+
+ - relay WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged received in ElementsPanel on WebInspector.notifications;
+
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype._selectedNodeChanged):
+ * inspector/front-end/ExtensionServer.js:
+
2012-08-17 Jan Keromnes <[email protected]>
Web Inspector: SourceFrame shouldn't be a View
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (125880 => 125881)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2012-08-17 11:42:08 UTC (rev 125880)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2012-08-17 12:06:27 UTC (rev 125881)
@@ -206,6 +206,7 @@
ConsoleAgent.addInspectedNode(selectedNode.id);
this._lastValidSelectedNode = selectedNode;
}
+ WebInspector.notifications.dispatchEventToListeners(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged);
},
_updateSidebars: function()
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionServer.js (125880 => 125881)
--- trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2012-08-17 11:42:08 UTC (rev 125880)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2012-08-17 12:06:27 UTC (rev 125881)
@@ -574,17 +574,10 @@
WebInspector.workspace,
WebInspector.UISourceCodeProvider.Events.UISourceCodeAdded,
this._notifyResourceAdded);
- this._registerSubscriptionHandler(WebInspector.extensionAPI.Events.ElementsPanelObjectSelected,
- function()
- {
- WebInspector.panel("elements").treeOutline.addEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, this._notifyElementsSelectionChanged, this);
- }.bind(this),
- function()
- {
- WebInspector.panel("elements").treeOutline.removeEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, this._notifyElementsSelectionChanged, this);
- }.bind(this)
- );
-
+ this._registerAutosubscriptionHandler(WebInspector.extensionAPI.Events.ElementsPanelObjectSelected,
+ WebInspector.notifications,
+ WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged,
+ this._notifyElementsSelectionChanged);
this._registerAutosubscriptionHandler(WebInspector.extensionAPI.Events.ResourceContentCommitted,
WebInspector.workspace,
WebInspector.Workspace.Events.UISourceCodeContentCommitted,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
