Title: [125948] trunk/Source/WebCore
- Revision
- 125948
- Author
- [email protected]
- Date
- 2012-08-17 16:36:46 -0700 (Fri, 17 Aug 2012)
Log Message
[BlackBerry][EFL] Remove compile warning in WebCore
https://bugs.webkit.org/show_bug.cgi?id=94328
Patch by Kangil Han <[email protected]> on 2012-08-17
Reviewed by Rob Buis.
Fixed compile time warning in WebCore.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125947 => 125948)
--- trunk/Source/WebCore/ChangeLog 2012-08-17 23:35:22 UTC (rev 125947)
+++ trunk/Source/WebCore/ChangeLog 2012-08-17 23:36:46 UTC (rev 125948)
@@ -1,3 +1,17 @@
+2012-08-17 Kangil Han <[email protected]>
+
+ [BlackBerry][EFL] Remove compile warning in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=94328
+
+ Reviewed by Rob Buis.
+
+ Fixed compile time warning in WebCore.
+
+ * platform/efl/RenderThemeEfl.cpp:
+ (WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
+ * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
+ (WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti
+
2012-08-17 Arnaud Renevier <[email protected]>
[V8] use checkInboundData in setWebGLArrayHelper
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (125947 => 125948)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-17 23:35:22 UTC (rev 125947)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-17 23:36:46 UTC (rev 125948)
@@ -453,6 +453,7 @@
else if (!edje_object_file_set(m_edje, m_themePath.utf8().data(), "webkit/base")) {
Edje_Load_Error err = edje_object_load_error_get(m_edje);
const char* errmsg = edje_load_error_str(err);
+ EINA_LOG_ERR("Could not set file: %s", errmsg);
evas_object_del(m_edje);
m_edje = 0;
} else {
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp (125947 => 125948)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp 2012-08-17 23:35:22 UTC (rev 125947)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp 2012-08-17 23:36:46 UTC (rev 125948)
@@ -403,8 +403,8 @@
FloatRect HarfBuzzShaper::selectionRect(const FloatPoint& point, int height, int from, int to)
{
float currentX = 0;
- float fromX;
- float toX;
+ float fromX = 0;
+ float toX = 0;
bool foundFromX = false;
bool foundToX = false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
