Title: [126031] trunk/Source
- Revision
- 126031
- Author
- [email protected]
- Date
- 2012-08-20 08:18:17 -0700 (Mon, 20 Aug 2012)
Log Message
[Qt] Custom tap-highlight-color renders fully opaque
https://bugs.webkit.org/show_bug.cgi?id=94468
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Adjust the default tap-highlight-color to figure in that is will be
drawn semi-transparent.
* rendering/RenderTheme.h:
(RenderTheme):
Source/WebKit2:
Draw tap-highlight-color at 50% transparency, to better match how
existing WebKit browsers act on custom tap-highlight colors.
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126030 => 126031)
--- trunk/Source/WebCore/ChangeLog 2012-08-20 15:10:55 UTC (rev 126030)
+++ trunk/Source/WebCore/ChangeLog 2012-08-20 15:18:17 UTC (rev 126031)
@@ -1,3 +1,16 @@
+2012-08-20 Allan Sandfeld Jensen <[email protected]>
+
+ [Qt] Custom tap-highlight-color renders fully opaque
+ https://bugs.webkit.org/show_bug.cgi?id=94468
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Adjust the default tap-highlight-color to figure in that is will be
+ drawn semi-transparent.
+
+ * rendering/RenderTheme.h:
+ (RenderTheme):
+
2012-08-20 Andrey Adaikin <[email protected]>
Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (126030 => 126031)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2012-08-20 15:10:55 UTC (rev 126030)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2012-08-20 15:18:17 UTC (rev 126031)
@@ -365,7 +365,9 @@
mutable Color m_inactiveListBoxSelectionForegroundColor;
#if ENABLE(TOUCH_EVENTS)
- static const RGBA32 defaultTapHighlightColor = 0x33000000;
+ // This color is expected to be drawn on a semi-transparent overlay,
+ // making it more transparent than its alpha value indicates.
+ static const RGBA32 defaultTapHighlightColor = 0x66000000;
#endif
#if USE(NEW_THEME)
Modified: trunk/Source/WebKit2/ChangeLog (126030 => 126031)
--- trunk/Source/WebKit2/ChangeLog 2012-08-20 15:10:55 UTC (rev 126030)
+++ trunk/Source/WebKit2/ChangeLog 2012-08-20 15:18:17 UTC (rev 126031)
@@ -1,3 +1,16 @@
+2012-08-20 Allan Sandfeld Jensen <[email protected]>
+
+ [Qt] Custom tap-highlight-color renders fully opaque
+ https://bugs.webkit.org/show_bug.cgi?id=94468
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Draw tap-highlight-color at 50% transparency, to better match how
+ existing WebKit browsers act on custom tap-highlight colors.
+
+ * WebProcess/WebPage/TapHighlightController.cpp:
+ (WebKit::TapHighlightController::drawRect):
+
2012-08-20 Carlos Garcia Campos <[email protected]>
[GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp (126030 => 126031)
--- trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-08-20 15:10:55 UTC (rev 126030)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-08-20 15:18:17 UTC (rev 126031)
@@ -105,9 +105,9 @@
{
GraphicsContextStateSaver stateSaver(context);
if (m_webPage->drawingArea()->pageOverlayShouldApplyFadeWhenPainting())
- context.setFillColor(highlightColor(m_color, pageOverlay->fractionFadedIn()), ColorSpaceSRGB);
+ context.setFillColor(highlightColor(m_color, pageOverlay->fractionFadedIn() * 0.5f), ColorSpaceSRGB);
else
- context.setFillColor(m_color, ColorSpaceSRGB);
+ context.setFillColor(highlightColor(m_color, 0.5f), ColorSpaceSRGB);
context.fillPath(m_path);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
