Title: [126038] releases/WebKitGTK/webkit-1.8/Source/WebCore
- Revision
- 126038
- Author
- [email protected]
- Date
- 2012-08-20 09:18:41 -0700 (Mon, 20 Aug 2012)
Log Message
Merge 125326 - [GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Patch by Mario Sanchez Prada <[email protected]> on 2012-08-10
Rubber-stamped by Ryosuke Niwa.
Fix Apple Win build, by avoiding to generate unreachable sections
of code in AccessibilityRenderObject::passwordFieldValue().
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::passwordFieldValue):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (126037 => 126038)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-08-20 16:18:36 UTC (rev 126037)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-08-20 16:18:41 UTC (rev 126038)
@@ -3,6 +3,19 @@
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
+ Rubber-stamped by Ryosuke Niwa.
+
+ Fix Apple Win build, by avoiding to generate unreachable sections
+ of code in AccessibilityRenderObject::passwordFieldValue().
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::passwordFieldValue):
+
+2012-08-10 Mario Sanchez Prada <[email protected]>
+
+ [GTK] Broken implementation of AtkText and AtkEditableText for password fields
+ https://bugs.webkit.org/show_bug.cgi?id=93621
+
Reviewed by Chris Fleizach.
Fix broken implementation of AtkText and AtkEditableText
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (126037 => 126038)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-08-20 16:18:36 UTC (rev 126037)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-08-20 16:18:41 UTC (rev 126038)
@@ -3949,11 +3949,7 @@
String AccessibilityRenderObject::passwordFieldValue() const
{
-#if !PLATFORM(GTK)
- // It seems only GTK is interested in this at the moment.
- return String();
-#endif
-
+#if PLATFORM(GTK)
ASSERT(isPasswordField());
// Look for the RenderText object in the RenderObject tree for this input field.
@@ -3966,6 +3962,10 @@
// Return the text that is actually being rendered in the input field.
return static_cast<RenderText*>(renderer)->textWithoutTranscoding();
+#else
+ // It seems only GTK is interested in this at the moment.
+ return String();
+#endif
}
ScrollableArea* AccessibilityRenderObject::getScrollableAreaIfScrollable() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
