Title: [126042] trunk/Source/WebCore
- Revision
- 126042
- Author
- [email protected]
- Date
- 2012-08-20 11:01:40 -0700 (Mon, 20 Aug 2012)
Log Message
[chromium] pepper plugins sometimes are shifted by 1 pixel
https://bugs.webkit.org/show_bug.cgi?id=94257
Patch by Yuzhu Shen <[email protected]> on 2012-08-20
Reviewed by Levi Weintraub.
Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).
This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.
No new tests because we don't have Pepper plugin tests in WebKit.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126041 => 126042)
--- trunk/Source/WebCore/ChangeLog 2012-08-20 16:53:36 UTC (rev 126041)
+++ trunk/Source/WebCore/ChangeLog 2012-08-20 18:01:40 UTC (rev 126042)
@@ -1,3 +1,22 @@
+2012-08-20 Yuzhu Shen <[email protected]>
+
+ [chromium] pepper plugins sometimes are shifted by 1 pixel
+ https://bugs.webkit.org/show_bug.cgi?id=94257
+
+ Reviewed by Levi Weintraub.
+
+ Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
+ (when converting from FloatRect to IntRect).
+
+ This makes sure that the optimized rendering code path of Pepper plugin
+ (PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
+ code path.
+
+ No new tests because we don't have Pepper plugin tests in WebKit.
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::updateWidgetGeometry):
+
2012-08-20 Christophe Dumez <[email protected]>
postMessage() in MessagePort.idl does not match spec
Modified: trunk/Source/WebCore/rendering/RenderWidget.cpp (126041 => 126042)
--- trunk/Source/WebCore/rendering/RenderWidget.cpp 2012-08-20 16:53:36 UTC (rev 126041)
+++ trunk/Source/WebCore/rendering/RenderWidget.cpp 2012-08-20 18:01:40 UTC (rev 126042)
@@ -176,11 +176,11 @@
bool RenderWidget::updateWidgetGeometry()
{
- IntRect contentBox = pixelSnappedIntRect(contentBoxRect());
+ LayoutRect contentBox = contentBoxRect();
if (!m_widget->transformsAffectFrameRect())
return setWidgetGeometry(absoluteContentBox());
- IntRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
+ LayoutRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
if (m_widget->isFrameView()) {
contentBox.setLocation(absoluteContentBox.location());
return setWidgetGeometry(contentBox);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
