Diff
Modified: trunk/Source/WebCore/ChangeLog (126047 => 126048)
--- trunk/Source/WebCore/ChangeLog 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/ChangeLog 2012-08-20 18:52:25 UTC (rev 126048)
@@ -1,3 +1,35 @@
+2012-08-20 Julien Chaffraix <[email protected]>
+
+ Introduce a will-be-removed-from-tree notification in RenderObject
+ https://bugs.webkit.org/show_bug.cgi?id=94271
+
+ Reviewed by Abhishek Arya.
+
+ Following bug 93874, we have an insertion notification. This change adds the
+ matching removal notification (willBeRemovedFromTree).
+
+ Refactoring covered by existing tests.
+
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::removeChildNode):
+ Removed the code from here and moved it below.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::willBeRemovedFromTree):
+ * rendering/RenderObject.h:
+ This is the base function that should be called by every instance.
+
+ * rendering/RenderListItem.cpp:
+ (WebCore::RenderListItem::willBeRemovedFromTree):
+ * rendering/RenderListItem.h:
+ * rendering/RenderQuote.cpp:
+ (WebCore::RenderQuote::willBeRemovedFromTree):
+ * rendering/RenderQuote.h:
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::willBeRemovedFromTree):
+ * rendering/RenderRegion.h:
+ Overriden functions.
+
2012-08-20 Mike West <[email protected]>
CSP 1.1: The 'plugin-types' warning should include details about explicit type declaration when relevant.
Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderListItem.cpp 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp 2012-08-20 18:52:25 UTC (rev 126048)
@@ -83,6 +83,13 @@
updateListMarkerNumbers();
}
+void RenderListItem::willBeRemovedFromTree()
+{
+ RenderBlock::willBeRemovedFromTree();
+
+ updateListMarkerNumbers();
+}
+
static bool isList(Node* node)
{
return (node->hasTagName(ulTag) || node->hasTagName(olTag));
Modified: trunk/Source/WebCore/rendering/RenderListItem.h (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderListItem.h 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderListItem.h 2012-08-20 18:52:25 UTC (rev 126048)
@@ -59,6 +59,7 @@
virtual void willBeDestroyed();
virtual void insertedIntoTree() OVERRIDE;
+ virtual void willBeRemovedFromTree() OVERRIDE;
virtual bool isEmpty() const;
virtual void paint(PaintInfo&, const LayoutPoint&);
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2012-08-20 18:52:25 UTC (rev 126048)
@@ -2395,6 +2395,42 @@
containerFlowThread->addFlowChild(this);
}
+void RenderObject::willBeRemovedFromTree()
+{
+ // FIXME: We should ASSERT(isRooted()) but we have some out-of-order removals which would need to be fixed first.
+
+ // If we remove a visible child from an invisible parent, we don't know the layer visibility any more.
+ RenderLayer* layer = 0;
+ if (parent()->style()->visibility() != VISIBLE && style()->visibility() == VISIBLE && !hasLayer()) {
+ if ((layer = parent()->enclosingLayer()))
+ layer->dirtyVisibleContentStatus();
+ }
+
+ // Keep our layer hierarchy updated.
+ if (firstChild() || hasLayer()) {
+ if (!layer)
+ layer = parent()->enclosingLayer();
+ removeLayers(layer);
+ }
+
+ if (isOutOfFlowPositioned() && parent()->childrenInline())
+ parent()->dirtyLinesFromChangedChild(this);
+
+ if (inRenderFlowThread()) {
+ if (isBox())
+ enclosingRenderFlowThread()->removeRenderBoxRegionInfo(toRenderBox(this));
+ enclosingRenderFlowThread()->clearRenderObjectCustomStyle(this);
+ }
+
+ if (RenderNamedFlowThread* containerFlowThread = parent()->enclosingRenderNamedFlowThread())
+ containerFlowThread->removeFlowChild(this);
+
+#if ENABLE(SVG)
+ // Update cached boundaries in SVG renderers, if a child is removed.
+ parent()->setNeedsBoundariesUpdate();
+#endif
+}
+
void RenderObject::destroyAndCleanupAnonymousWrappers()
{
RenderObject* parent = this->parent();
Modified: trunk/Source/WebCore/rendering/RenderObject.h (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderObject.h 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2012-08-20 18:52:25 UTC (rev 126048)
@@ -939,6 +939,7 @@
virtual bool canBeReplacedWithInlineRunIn() const;
virtual void insertedIntoTree();
+ virtual void willBeRemovedFromTree();
private:
RenderStyle* firstLineStyleSlowCase() const;
Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.cpp (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2012-08-20 18:52:25 UTC (rev 126048)
@@ -63,7 +63,7 @@
}
}
-RenderObject* RenderObjectChildList::removeChildNode(RenderObject* owner, RenderObject* oldChild, bool fullRemove)
+RenderObject* RenderObjectChildList::removeChildNode(RenderObject* owner, RenderObject* oldChild, bool notifyRenderer)
{
ASSERT(oldChild->parent() == owner);
@@ -73,7 +73,7 @@
// So that we'll get the appropriate dirty bit set (either that a normal flow child got yanked or
// that a positioned child got yanked). We also repaint, so that the area exposed when the child
// disappears gets repainted properly.
- if (!owner->documentBeingDestroyed() && fullRemove && oldChild->everHadLayout()) {
+ if (!owner->documentBeingDestroyed() && notifyRenderer && oldChild->everHadLayout()) {
oldChild->setNeedsLayoutAndPrefWidthsRecalc();
if (oldChild->isBody())
owner->view()->repaint();
@@ -85,47 +85,8 @@
if (oldChild->isBox())
toRenderBox(oldChild)->deleteLineBoxWrapper();
- if (!owner->documentBeingDestroyed() && fullRemove) {
- // if we remove visible child from an invisible parent, we don't know the layer visibility any more
- RenderLayer* layer = 0;
- if (owner->style()->visibility() != VISIBLE && oldChild->style()->visibility() == VISIBLE && !oldChild->hasLayer()) {
- if ((layer = owner->enclosingLayer()))
- layer->dirtyVisibleContentStatus();
- }
-
- // Keep our layer hierarchy updated.
- if (oldChild->firstChild() || oldChild->hasLayer()) {
- if (!layer)
- layer = owner->enclosingLayer();
- oldChild->removeLayers(layer);
- }
-
- if (oldChild->isListItem())
- toRenderListItem(oldChild)->updateListMarkerNumbers();
-
- if (oldChild->isOutOfFlowPositioned() && owner->childrenInline())
- owner->dirtyLinesFromChangedChild(oldChild);
-
- if (oldChild->isRenderRegion())
- toRenderRegion(oldChild)->detachRegion();
-
- if (oldChild->isQuote())
- toRenderQuote(oldChild)->detachQuote();
-
- if (oldChild->inRenderFlowThread()) {
- if (oldChild->isBox())
- oldChild->enclosingRenderFlowThread()->removeRenderBoxRegionInfo(toRenderBox(oldChild));
- oldChild->enclosingRenderFlowThread()->clearRenderObjectCustomStyle(oldChild);
- }
-
- if (RenderNamedFlowThread* containerFlowThread = owner->enclosingRenderNamedFlowThread())
- containerFlowThread->removeFlowChild(oldChild);
-
-#if ENABLE(SVG)
- // Update cached boundaries in SVG renderers, if a child is removed.
- owner->setNeedsBoundariesUpdate();
-#endif
- }
+ if (!owner->documentBeingDestroyed() && notifyRenderer)
+ oldChild->willBeRemovedFromTree();
// If oldChild is the start or end of the selection, then clear the selection to
// avoid problems of invalid pointers.
Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.h (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderObjectChildList.h 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.h 2012-08-20 18:52:25 UTC (rev 126048)
@@ -52,7 +52,7 @@
void destroyLeftoverChildren();
- RenderObject* removeChildNode(RenderObject* owner, RenderObject*, bool fullRemove = true);
+ RenderObject* removeChildNode(RenderObject* owner, RenderObject*, bool notifyRenderer = true);
void appendChildNode(RenderObject* owner, RenderObject*, bool notifyRenderer = true);
void insertChildNode(RenderObject* owner, RenderObject* child, RenderObject* before, bool notifyRenderer = true);
Modified: trunk/Source/WebCore/rendering/RenderQuote.cpp (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderQuote.cpp 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderQuote.cpp 2012-08-20 18:52:25 UTC (rev 126048)
@@ -50,6 +50,13 @@
RenderText::willBeDestroyed();
}
+void RenderQuote::willBeRemovedFromTree()
+{
+ RenderText::willBeRemovedFromTree();
+
+ detachQuote();
+}
+
typedef HashMap<AtomicString, const QuotesData*, CaseFoldingHash> QuotesMap;
static const QuotesMap& quotesDataLanguageMap()
Modified: trunk/Source/WebCore/rendering/RenderQuote.h (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderQuote.h 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderQuote.h 2012-08-20 18:52:25 UTC (rev 126048)
@@ -49,6 +49,8 @@
// renderers before going into the main render tree. Once we can ensure that insertIntoTree,
// is called on an attached tree, we should override it here.
+ virtual void willBeRemovedFromTree() OVERRIDE;
+
const QuotesData* quotesData() const;
void updateDepth();
bool isAttached() { return m_attached; }
Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderRegion.cpp 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp 2012-08-20 18:52:25 UTC (rev 126048)
@@ -364,6 +364,13 @@
attachRegion();
}
+void RenderRegion::willBeRemovedFromTree()
+{
+ RenderReplaced::willBeRemovedFromTree();
+
+ detachRegion();
+}
+
PassRefPtr<RenderStyle> RenderRegion::computeStyleInRegion(const RenderObject* object)
{
ASSERT(object);
Modified: trunk/Source/WebCore/rendering/RenderRegion.h (126047 => 126048)
--- trunk/Source/WebCore/rendering/RenderRegion.h 2012-08-20 18:33:20 UTC (rev 126047)
+++ trunk/Source/WebCore/rendering/RenderRegion.h 2012-08-20 18:52:25 UTC (rev 126048)
@@ -101,6 +101,7 @@
virtual const char* renderName() const { return "RenderRegion"; }
virtual void insertedIntoTree() OVERRIDE;
+ virtual void willBeRemovedFromTree() OVERRIDE;
PassRefPtr<RenderStyle> computeStyleInRegion(const RenderObject*);
void computeChildrenStyleInRegion(const RenderObject*);
