Title: [126062] trunk/Tools
- Revision
- 126062
- Author
- [email protected]
- Date
- 2012-08-20 13:59:47 -0700 (Mon, 20 Aug 2012)
Log Message
Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
https://bugs.webkit.org/show_bug.cgi?id=94505
Reviewed by Ojan Vafai.
It looks like if the webprocess times out, WTR may tell NRWT
that the test completed, but not properly reset its internal
state, and then return stale output for subsequent tests.
This patch modifies NRWT temporarily to check for
"Timed out waiting for final message from web process" in stdout
and treat that as a timeout (and thus kill WTR); this seems
to solve the cascade of failures, but of course there's probably
still a bug in WTR that needs to be fixed.
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126061 => 126062)
--- trunk/Tools/ChangeLog 2012-08-20 20:48:52 UTC (rev 126061)
+++ trunk/Tools/ChangeLog 2012-08-20 20:59:47 UTC (rev 126062)
@@ -1,5 +1,25 @@
2012-08-20 Dirk Pranke <[email protected]>
+ Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
+ https://bugs.webkit.org/show_bug.cgi?id=94505
+
+ Reviewed by Ojan Vafai.
+
+ It looks like if the webprocess times out, WTR may tell NRWT
+ that the test completed, but not properly reset its internal
+ state, and then return stale output for subsequent tests.
+
+ This patch modifies NRWT temporarily to check for
+ "Timed out waiting for final message from web process" in stdout
+ and treat that as a timeout (and thus kill WTR); this seems
+ to solve the cascade of failures, but of course there's probably
+ still a bug in WTR that needs to be fixed.
+
+ * Scripts/webkitpy/layout_tests/port/driver.py:
+ (Driver.run_test):
+
+2012-08-20 Dirk Pranke <[email protected]>
+
NRWT reports unexpected EOF
https://bugs.webkit.org/show_bug.cgi?id=94387
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (126061 => 126062)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-08-20 20:48:52 UTC (rev 126061)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-08-20 20:59:47 UTC (rev 126062)
@@ -160,6 +160,12 @@
crashed = self.has_crashed()
timed_out = self._server_process.timed_out
+ if 'Timed out waiting for final message from web process' in text:
+ if not timed_out:
+ _log.warning("webprocess timed out but WTR didn't, killing WTR")
+ timed_out = True
+ else:
+ _log.warning("webprocess timed out and so did WTR")
if stop_when_done or crashed or timed_out:
# We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
