Title: [126064] trunk/Tools
Revision
126064
Author
[email protected]
Date
2012-08-20 14:03:07 -0700 (Mon, 20 Aug 2012)

Log Message

Add missing FIXME: to previous change.
https://bugs.webkit.org/show_bug.cgi?id=94505

Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (126063 => 126064)


--- trunk/Tools/ChangeLog	2012-08-20 21:02:32 UTC (rev 126063)
+++ trunk/Tools/ChangeLog	2012-08-20 21:03:07 UTC (rev 126064)
@@ -1,5 +1,15 @@
 2012-08-20  Dirk Pranke  <[email protected]>
 
+        Add missing FIXME: to previous change.
+        https://bugs.webkit.org/show_bug.cgi?id=94505
+
+        Reviewed by Ojan Vafai.
+
+        * Scripts/webkitpy/layout_tests/port/driver.py:
+        (Driver.run_test):
+
+2012-08-20  Dirk Pranke  <[email protected]>
+
         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
         https://bugs.webkit.org/show_bug.cgi?id=94505
 

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (126063 => 126064)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py	2012-08-20 21:02:32 UTC (rev 126063)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py	2012-08-20 21:03:07 UTC (rev 126064)
@@ -161,6 +161,8 @@
         crashed = self.has_crashed()
         timed_out = self._server_process.timed_out
         if 'Timed out waiting for final message from web process' in text:
+            # FIXME: This is a hack to work around the issues in https://bugs.webkit.org/show_bug.cgi?id=94505.
+            # We need to either fix the underlying problem in WTR or return a more canonical error.
             if not timed_out:
                 _log.warning("webprocess timed out but WTR didn't, killing WTR")
                 timed_out = True
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to