Title: [126166] trunk/Source/WebKit/blackberry
- Revision
- 126166
- Author
- [email protected]
- Date
- 2012-08-21 10:02:28 -0700 (Tue, 21 Aug 2012)
Log Message
[BlackBerry] Properly notify WebKit when Client stops in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=94603
PR #195813
Reviewed by Goerge Staikos.
Patch by Antonio Gomes <[email protected]>
Simplify the API to get a notification of when a in-region
scrolling has finished.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
Removed an unneeded parameter.
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
Ditto.
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (126165 => 126166)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-08-21 16:54:26 UTC (rev 126165)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-08-21 17:02:28 UTC (rev 126166)
@@ -1497,17 +1497,17 @@
return b;
}
-void WebPagePrivate::notifyInRegionScrollStatusChanged(bool status)
+void WebPagePrivate::notifyInRegionScrollStopped()
{
- if (!status && m_inRegionScroller->d->hasNode()) {
+ if (m_inRegionScroller->d->hasNode()) {
enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling(m_inRegionScroller->d->node());
m_inRegionScroller->d->reset();
}
}
-void WebPage::notifyInRegionScrollStatusChanged(bool status)
+void WebPage::notifyInRegionScrollStopped()
{
- d->notifyInRegionScrollStatusChanged(status);
+ d->notifyInRegionScrollStopped();
}
void WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling(Node* scrolledNode)
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (126165 => 126166)
--- trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-08-21 16:54:26 UTC (rev 126165)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h 2012-08-21 17:02:28 UTC (rev 126166)
@@ -176,7 +176,7 @@
// Scroll position provided should be in transformed coordinates.
void setScrollPosition(const Platform::IntPoint&);
bool scrollBy(const Platform::IntSize&, bool scrollMainFrame = true);
- void notifyInRegionScrollStatusChanged(bool status);
+ void notifyInRegionScrollStopped();
void setScrollOriginPoint(const Platform::IntPoint&);
BackingStore* backingStore() const;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (126165 => 126166)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-08-21 16:54:26 UTC (rev 126165)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-08-21 17:02:28 UTC (rev 126166)
@@ -150,7 +150,7 @@
bool scrollBy(int deltaX, int deltaY, bool scrollMainFrame = true);
void enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling(WebCore::Node*);
- void notifyInRegionScrollStatusChanged(bool status);
+ void notifyInRegionScrollStopped();
void setScrollOriginPoint(const Platform::IntPoint&);
void setHasInRegionScrollableAreas(bool);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (126165 => 126166)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-21 16:54:26 UTC (rev 126165)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-21 17:02:28 UTC (rev 126166)
@@ -1,3 +1,23 @@
+2012-08-21 Antonio Gomes <[email protected]>
+
+ [BlackBerry] Properly notify WebKit when Client stops in-region scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=94603
+ PR #195813
+
+ Reviewed by Goerge Staikos.
+
+ Simplify the API to get a notification of when a in-region
+ scrolling has finished.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
+ Removed an unneeded parameter.
+ (BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
+ Ditto.
+ * Api/WebPage.h:
+ * Api/WebPage_p.h:
+ (WebPagePrivate):
+
2012-08-20 Sean Wang <[email protected]>
[BlackBerry] Select popup shows blank content when its option tags contain '\' characters
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
