Title: [126212] trunk/Tools
- Revision
- 126212
- Author
- [email protected]
- Date
- 2012-08-21 16:24:01 -0700 (Tue, 21 Aug 2012)
Log Message
[Chromium] DRT produces wrong back-forward list
https://bugs.webkit.org/show_bug.cgi?id=94575
Reviewed by Adam Barth.
DRT clears its history state before running every tests. However
HistoryController in WebCore isn't reset. So, it is possible that
'isNewNavigation' flag is false even though the navigation should be
handled as "new" for DRT.
This change might fix a problem of
fast/forms/select/select-state-restore.html (Bug 90207).
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):
Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
Without this change, a navigation entry for this loading won't be recorded.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126211 => 126212)
--- trunk/Tools/ChangeLog 2012-08-21 23:22:09 UTC (rev 126211)
+++ trunk/Tools/ChangeLog 2012-08-21 23:24:01 UTC (rev 126212)
@@ -1,3 +1,23 @@
+2012-08-21 Kent Tamura <[email protected]>
+
+ [Chromium] DRT produces wrong back-forward list
+ https://bugs.webkit.org/show_bug.cgi?id=94575
+
+ Reviewed by Adam Barth.
+
+ DRT clears its history state before running every tests. However
+ HistoryController in WebCore isn't reset. So, it is possible that
+ 'isNewNavigation' flag is false even though the navigation should be
+ handled as "new" for DRT.
+
+ This change might fix a problem of
+ fast/forms/select/select-state-restore.html (Bug 90207).
+
+ * DumpRenderTree/chromium/WebViewHost.cpp:
+ (WebViewHost::updateForCommittedLoad):
+ Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
+ Without this change, a navigation entry for this loading won't be recorded.
+
2012-08-21 Thiago Marcos P. Santos <[email protected]>
[EFL] Enable CSS Text Decoration by default
Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (126211 => 126212)
--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2012-08-21 23:22:09 UTC (rev 126211)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2012-08-21 23:24:01 UTC (rev 126212)
@@ -1672,8 +1672,9 @@
{
// Code duplicated from RenderView::DidCommitLoadForFrame.
TestShellExtraData* extraData = static_cast<TestShellExtraData*>(frame->dataSource()->extraData());
+ bool nonBlankPageAfterReset = m_pageId == -1 && strcmp(frame->dataSource()->request().url().spec().data(), "about:blank");
- if (isNewNavigation) {
+ if (isNewNavigation || nonBlankPageAfterReset) {
// New navigation.
updateSessionHistory(frame);
m_pageId = nextPageID++;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
