Title: [126292] trunk
- Revision
- 126292
- Author
- [email protected]
- Date
- 2012-08-22 05:48:46 -0700 (Wed, 22 Aug 2012)
Log Message
[EFL] Support slider tick mark snapping
https://bugs.webkit.org/show_bug.cgi?id=94560
Patch by KwangYong Choi <[email protected]> on 2012-08-22
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Increased the threshold for the EFL port. The value is snapped
when it clicked near tick mark.
No new tests. Covered by fast/forms/datalist/range-snap-to-datalist.html.
* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::sliderTickSnappingThreshold):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
LayoutTests:
The expected result of fast/forms/datalist/range-snap-to-datalist.html
is updated because slider tick mark snapping threshold is changed.
* platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (126291 => 126292)
--- trunk/LayoutTests/ChangeLog 2012-08-22 12:46:06 UTC (rev 126291)
+++ trunk/LayoutTests/ChangeLog 2012-08-22 12:48:46 UTC (rev 126292)
@@ -1,3 +1,15 @@
+2012-08-22 KwangYong Choi <[email protected]>
+
+ [EFL] Support slider tick mark snapping
+ https://bugs.webkit.org/show_bug.cgi?id=94560
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ The expected result of fast/forms/datalist/range-snap-to-datalist.html
+ is updated because slider tick mark snapping threshold is changed.
+
+ * platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:
+
2012-08-22 Dominik Röttsches <[email protected]>
[EFL] Unreviewed gardening.
Modified: trunk/LayoutTests/platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt (126291 => 126292)
--- trunk/LayoutTests/platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt 2012-08-22 12:46:06 UTC (rev 126291)
+++ trunk/LayoutTests/platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt 2012-08-22 12:48:46 UTC (rev 126292)
@@ -5,17 +5,17 @@
value for 42 is <500
value for 43 is <500
value for 44 is <500
-value for 45 is <500
-value for 46 is <500
-value for 47 is <500
-value for 48 is <500
-value for 49 is <500
+value for 45 is =500
+value for 46 is =500
+value for 47 is =500
+value for 48 is =500
+value for 49 is =500
value for 50 is =500
-value for 51 is >500
-value for 52 is >500
-value for 53 is >500
-value for 54 is >500
-value for 55 is >500
+value for 51 is =500
+value for 52 is =500
+value for 53 is =500
+value for 54 is =500
+value for 55 is =500
value for 56 is >500
value for 57 is >500
value for 58 is >500
Modified: trunk/Source/WebCore/ChangeLog (126291 => 126292)
--- trunk/Source/WebCore/ChangeLog 2012-08-22 12:46:06 UTC (rev 126291)
+++ trunk/Source/WebCore/ChangeLog 2012-08-22 12:48:46 UTC (rev 126292)
@@ -1,3 +1,21 @@
+2012-08-22 KwangYong Choi <[email protected]>
+
+ [EFL] Support slider tick mark snapping
+ https://bugs.webkit.org/show_bug.cgi?id=94560
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Increased the threshold for the EFL port. The value is snapped
+ when it clicked near tick mark.
+
+ No new tests. Covered by fast/forms/datalist/range-snap-to-datalist.html.
+
+ * platform/efl/RenderThemeEfl.cpp:
+ (WebCore):
+ (WebCore::RenderThemeEfl::sliderTickSnappingThreshold):
+ * platform/efl/RenderThemeEfl.h:
+ (RenderThemeEfl):
+
2012-08-22 Allan Sandfeld Jensen <[email protected]>
[Qt] Optionally support smooth-scrolling on all platforms
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (126291 => 126292)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-22 12:46:06 UTC (rev 126291)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-22 12:48:46 UTC (rev 126292)
@@ -809,6 +809,12 @@
return sliderTickOffset;
}
+
+LayoutUnit RenderThemeEfl::sliderTickSnappingThreshold() const
+{
+ // The same threshold value as the Chromium port.
+ return 5;
+}
#endif
bool RenderThemeEfl::supportsDataListUI(const AtomicString& type) const
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.h (126291 => 126292)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.h 2012-08-22 12:46:06 UTC (rev 126291)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.h 2012-08-22 12:48:46 UTC (rev 126292)
@@ -164,6 +164,7 @@
#if ENABLE(DATALIST_ELEMENT)
virtual IntSize sliderTickSize() const OVERRIDE;
virtual int sliderTickOffsetFromTrackCenter() const OVERRIDE;
+ virtual LayoutUnit sliderTickSnappingThreshold() const OVERRIDE;
#endif
virtual bool supportsDataListUI(const AtomicString&) const OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
