Title: [126309] trunk
- Revision
- 126309
- Author
- [email protected]
- Date
- 2012-08-22 09:01:10 -0700 (Wed, 22 Aug 2012)
Log Message
REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
https://bugs.webkit.org/show_bug.cgi?id=94200
Reviewed by Chris Fleizach.
Tools:
Adds reference counting for AtkObjects referenced by
AccessibilityUIElementGtk. This prevents bogus results and
assertion failures on AccessibilityUIElements whose underlying
object has been deleted (as opposed to just made defunct).
This fixes two tests that were previously failing because of this bug.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
LayoutTests:
This patch fixes two tests and removes them from gtk expectations.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (126308 => 126309)
--- trunk/LayoutTests/ChangeLog 2012-08-22 15:54:59 UTC (rev 126308)
+++ trunk/LayoutTests/ChangeLog 2012-08-22 16:01:10 UTC (rev 126309)
@@ -1,3 +1,14 @@
+2012-08-22 Dominic Mazzoni <[email protected]>
+
+ REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
+ https://bugs.webkit.org/show_bug.cgi?id=94200
+
+ Reviewed by Chris Fleizach.
+
+ This patch fixes two tests and removes them from gtk expectations.
+
+ * platform/gtk/TestExpectations:
+
2012-08-22 Raul Hudea <[email protected]>
Crash in WebCore::RenderBlock::removeChild
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (126308 => 126309)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-08-22 15:54:59 UTC (rev 126308)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-08-22 16:01:10 UTC (rev 126309)
@@ -605,9 +605,6 @@
BUGWK79757 : fast/selectors/selection-window-inactive.html = IMAGE
-BUGWK94200 : accessibility/accessibility-node-memory-management.html = TEXT
-BUGWK94200 : accessibility/accessibility-node-reparent.html = TEXT
-
BUGWKGTK : accessibility/aria-hidden.html = TEXT
BUGWKGTK : accessibility/aria-hidden-with-elements.html = TEXT
BUGWKGTK : accessibility/aria-invalid.html = TEXT
Modified: trunk/Tools/ChangeLog (126308 => 126309)
--- trunk/Tools/ChangeLog 2012-08-22 15:54:59 UTC (rev 126308)
+++ trunk/Tools/ChangeLog 2012-08-22 16:01:10 UTC (rev 126309)
@@ -1,3 +1,21 @@
+2012-08-22 Dominic Mazzoni <[email protected]>
+
+ REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
+ https://bugs.webkit.org/show_bug.cgi?id=94200
+
+ Reviewed by Chris Fleizach.
+
+ Adds reference counting for AtkObjects referenced by
+ AccessibilityUIElementGtk. This prevents bogus results and
+ assertion failures on AccessibilityUIElements whose underlying
+ object has been deleted (as opposed to just made defunct).
+
+ This fixes two tests that were previously failing because of this bug.
+
+ * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+ (AccessibilityUIElement::AccessibilityUIElement):
+ (AccessibilityUIElement::~AccessibilityUIElement):
+
2012-08-22 Gustavo Noronha Silva <[email protected]>
[GTK] Split WebCore/platform into a separate library
Modified: trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (126308 => 126309)
--- trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-08-22 15:54:59 UTC (rev 126308)
+++ trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-08-22 16:01:10 UTC (rev 126309)
@@ -38,15 +38,18 @@
AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element)
: m_element(element)
{
+ g_object_ref(m_element);
}
AccessibilityUIElement::AccessibilityUIElement(const AccessibilityUIElement& other)
: m_element(other.m_element)
{
+ g_object_ref(m_element);
}
AccessibilityUIElement::~AccessibilityUIElement()
{
+ g_object_unref(m_element);
}
void AccessibilityUIElement::getLinkedUIElements(Vector<AccessibilityUIElement>& elements)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
