Title: [126327] trunk/Source/WebKit/chromium
- Revision
- 126327
- Author
- [email protected]
- Date
- 2012-08-22 12:09:05 -0700 (Wed, 22 Aug 2012)
Log Message
[chromium] Remove WebFrame::setSelectionToRange
https://bugs.webkit.org/show_bug.cgi?id=94685
Patch by Iain Merrick <[email protected]> on 2012-08-22
Reviewed by Adam Barth.
It has basically the same functionality as WebFrame::selectRange.
The calling code was removed in Chromium patch 152608.
* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (126326 => 126327)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-22 19:00:09 UTC (rev 126326)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-22 19:09:05 UTC (rev 126327)
@@ -1,3 +1,19 @@
+2012-08-22 Iain Merrick <[email protected]>
+
+ [chromium] Remove WebFrame::setSelectionToRange
+ https://bugs.webkit.org/show_bug.cgi?id=94685
+
+ Reviewed by Adam Barth.
+
+ It has basically the same functionality as WebFrame::selectRange.
+ The calling code was removed in Chromium patch 152608.
+
+ * public/WebFrame.h:
+ (WebFrame):
+ * src/WebFrameImpl.cpp:
+ * src/WebFrameImpl.h:
+ (WebFrameImpl):
+
2012-08-22 Kenneth Russell <[email protected]>
Unreviewed, rolling out r126319.
Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (126326 => 126327)
--- trunk/Source/WebKit/chromium/public/WebFrame.h 2012-08-22 19:00:09 UTC (rev 126326)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h 2012-08-22 19:09:05 UTC (rev 126327)
@@ -433,8 +433,6 @@
virtual WebRange markedRange() const = 0;
- virtual void setSelectionToRange(const WebRange&) = 0;
-
// Returns the frame rectangle in window coordinate space of the given text
// range.
virtual bool firstRectForCharacterRange(unsigned location, unsigned length, WebRect&) const = 0;
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (126326 => 126327)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-08-22 19:00:09 UTC (rev 126326)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-08-22 19:09:05 UTC (rev 126327)
@@ -1235,14 +1235,6 @@
return frame()->editor()->compositionRange();
}
-void WebFrameImpl::setSelectionToRange(const WebRange& range)
-{
- if (frame()->selection()->isContentEditable()) {
- RefPtr<Range> replacementRange = PassRefPtr<Range>(range);
- frame()->selection()->setSelection(VisibleSelection(replacementRange.get(), SEL_DEFAULT_AFFINITY));
- }
-}
-
bool WebFrameImpl::firstRectForCharacterRange(unsigned location, unsigned length, WebRect& rect) const
{
if ((location + length < location) && (location + length))
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.h (126326 => 126327)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2012-08-22 19:00:09 UTC (rev 126326)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2012-08-22 19:09:05 UTC (rev 126327)
@@ -169,7 +169,6 @@
virtual void unmarkText();
virtual bool hasMarkedText() const;
virtual WebRange markedRange() const;
- virtual void setSelectionToRange(const WebRange&) OVERRIDE;
virtual bool firstRectForCharacterRange(unsigned location, unsigned length, WebRect&) const;
virtual size_t characterIndexForPoint(const WebPoint&) const;
virtual bool executeCommand(const WebString&, const WebNode& = WebNode());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
