Title: [126434] trunk/Source/WebKit2
Revision
126434
Author
[email protected]
Date
2012-08-23 08:58:58 -0700 (Thu, 23 Aug 2012)

Log Message

[EFL][WK2] ewk_intent_request API test does not free Eina_List
https://bugs.webkit.org/show_bug.cgi?id=94809

Patch by Mikhail Pozdnyakov <[email protected]> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.

* UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(onIntentReceived):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (126433 => 126434)


--- trunk/Source/WebKit2/ChangeLog	2012-08-23 15:48:18 UTC (rev 126433)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-23 15:58:58 UTC (rev 126434)
@@ -1,3 +1,15 @@
+2012-08-23  Mikhail Pozdnyakov  <[email protected]>
+
+        [EFL][WK2] ewk_intent_request API test does not free Eina_List
+        https://bugs.webkit.org/show_bug.cgi?id=94809
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.
+
+        * UIProcess/API/efl/tests/test_ewk2_intents.cpp:
+        (onIntentReceived):
+
 2012-08-23  Andras Becsi  <[email protected]>
 
         [Qt][WK2] Helper functions used by the raw webview tests should not be guarded by HAVE_QTQUICK

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp (126433 => 126434)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp	2012-08-23 15:48:18 UTC (rev 126433)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp	2012-08-23 15:58:58 UTC (rev 126434)
@@ -92,6 +92,10 @@
         suggestions = eina_list_sort(suggestions, 2, stringSortCb);
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 0)), "http://service1.com/");
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 1)), "http://service2.com/");
+
+        void* listData = 0;
+        EINA_LIST_FREE(suggestions, listData)
+             eina_stringshare_del(static_cast<const char*>(listData));
     }
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to