Title: [126489] trunk/LayoutTests
Revision
126489
Author
[email protected]
Date
2012-08-23 15:50:05 -0700 (Thu, 23 Aug 2012)

Log Message

Adjust test expectations for fast/js/toString-overrides.html and fast/js/eval-cross-window.html
https://bugs.webkit.org/show_bug.cgi?id=94824

Patch by Ulan Degenbaev <[email protected]> on 2012-08-23
Reviewed by Kentaro Hara.

Add a bug number for tracking failing cases in fast/js/toString-overrides.html.
Upload Chromium specific test expectations for fast/js/eval-cross-window.html.

Failing tests in eval-cross-window swap the eval() function in the main window and the frame.
This behaviour is not specified in ECMA-262 and is probably implementation dependent.
Both Firefox and Chromium produce the same result for this test.

* platform/chromium/TestExpectations:
* platform/chromium/fast/js/eval-cross-window-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (126488 => 126489)


--- trunk/LayoutTests/ChangeLog	2012-08-23 22:48:25 UTC (rev 126488)
+++ trunk/LayoutTests/ChangeLog	2012-08-23 22:50:05 UTC (rev 126489)
@@ -1,3 +1,20 @@
+2012-08-23  Ulan Degenbaev  <[email protected]>
+
+        Adjust test expectations for fast/js/toString-overrides.html and fast/js/eval-cross-window.html
+        https://bugs.webkit.org/show_bug.cgi?id=94824
+
+        Reviewed by Kentaro Hara.
+
+        Add a bug number for tracking failing cases in fast/js/toString-overrides.html.
+        Upload Chromium specific test expectations for fast/js/eval-cross-window.html.
+
+        Failing tests in eval-cross-window swap the eval() function in the main window and the frame.
+        This behaviour is not specified in ECMA-262 and is probably implementation dependent.
+        Both Firefox and Chromium produce the same result for this test.
+
+        * platform/chromium/TestExpectations:
+        * platform/chromium/fast/js/eval-cross-window-expected.txt: Added.
+
 2012-08-23  Mike West  <[email protected]>
 
         Trailing spaces in CSP source lists should not generate console warnings.

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (126488 => 126489)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-23 22:48:25 UTC (rev 126488)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-23 22:50:05 UTC (rev 126489)
@@ -2720,8 +2720,7 @@
 BUGWK71451 SLOW : fast/frames/sandboxed-iframe-navigation-windowopen.html = PASS
 
 BUGWK94681 : fast/js/array-functions-non-arrays.html = TEXT
-BUGRICOW : fast/js/eval-cross-window.html = TEXT
-BUGRICOW : fast/js/toString-overrides.html = TEXT
+BUGWK94688 : fast/js/toString-overrides.html = TEXT
 
 BUGWK91944 : platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT
 

Added: trunk/LayoutTests/platform/chromium/fast/js/eval-cross-window-expected.txt (0 => 126489)


--- trunk/LayoutTests/platform/chromium/fast/js/eval-cross-window-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/js/eval-cross-window-expected.txt	2012-08-23 22:50:05 UTC (rev 126489)
@@ -0,0 +1,40 @@
+This page verifies that eval, when called as a function, uses the "this" object provided by the call as its variable object, scope chain, and "this" object. However, if the "this" object is not the global object eval was originally associated with, eval throws an exception.
+
+If the test passes, you'll see a series of pass messages below.
+
+
+----- Scope Chain Head for Getters: -----
+
+PASS: window.eval("x") should be 0 and is.
+PASS: frames[0].eval("x") should be 1 and is.
+FAIL: window.eval("x") should be EvalError but instead is 1.
+FAIL: frames[0].eval("x") should be EvalError but instead is undefined.
+
+----- Scope Chain for Getters: -----
+
+PASS: window.eval("xx") should be ReferenceError and is.
+PASS: frames[0].eval("xx") should be ReferenceError and is.
+FAIL: window.eval("xx") should be EvalError but instead is ReferenceError.
+FAIL: frames[0].eval("xx") should be EvalError but instead is ReferenceError.
+
+----- Variable Object: -----
+
+PASS: window.eval("var y; "y" in top") should be true and is.
+PASS: frames[0].eval("var y; "y" in top.frames[0]") should be true and is.
+FAIL: window.eval("var y; "y" in top.frames[0]") should be EvalError but instead is undefined.
+FAIL: frames[0].eval("var y; "y" in top") should be EvalError but instead is undefined.
+
+----- Scope Chain for Setters: -----
+
+PASS: window.eval("z = 1; top.z") should be 1 and is.
+PASS: frames[0].eval("z = 2; top.frames[0].z") should be 2 and is.
+FAIL: window.eval("z = 3; top.frames[0].z") should be EvalError but instead is undefined.
+FAIL: frames[0].eval("z = 4; top.z") should be EvalError but instead is undefined.
+
+----- This Object: -----
+
+PASS: window.eval("this") should be [object Window] and is.
+PASS: frames[0].eval("this") should be [object Window] and is.
+FAIL: window.eval("this") should be EvalError but instead is undefined.
+FAIL: frames[0].eval("this") should be EvalError but instead is undefined.
+
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to