Title: [126504] trunk/Source/WebCore
Revision
126504
Author
[email protected]
Date
2012-08-23 16:48:49 -0700 (Thu, 23 Aug 2012)

Log Message

[BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722

Patch by Otto Derek Cheung <[email protected]> on 2012-08-23
Reviewed by Rob Buis.

Changing the topleveldomain method name for better readability.

Also renaming the TopLevelDomain.h in platform to DomainTools
because there exists other tests that should belong in the same file.

Only changing method names and include file names.

* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (126503 => 126504)


--- trunk/Source/WebCore/ChangeLog	2012-08-23 23:41:09 UTC (rev 126503)
+++ trunk/Source/WebCore/ChangeLog	2012-08-23 23:48:49 UTC (rev 126504)
@@ -1,3 +1,21 @@
+2012-08-23  Otto Derek Cheung  <[email protected]>
+
+
+        [BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain 
+        https://bugs.webkit.org/show_bug.cgi?id=94722
+
+        Reviewed by Rob Buis.
+
+        Changing the topleveldomain method name for better readability.
+
+        Also renaming the TopLevelDomain.h in platform to DomainTools
+        because there exists other tests that should belong in the same file.
+
+        Only changing method names and include file names.
+
+        * platform/blackberry/CookieParser.cpp:
+        (WebCore::CookieParser::parseOneCookie):
+
 2012-08-23  Shezan Baig  <[email protected]>
 
         Fix cross-direction stretch for replaced elements in column flexbox

Modified: trunk/Source/WebCore/platform/blackberry/CookieParser.cpp (126503 => 126504)


--- trunk/Source/WebCore/platform/blackberry/CookieParser.cpp	2012-08-23 23:41:09 UTC (rev 126503)
+++ trunk/Source/WebCore/platform/blackberry/CookieParser.cpp	2012-08-23 23:48:49 UTC (rev 126504)
@@ -29,7 +29,7 @@
 
 #include "Logging.h"
 #include "ParsedCookie.h"
-#include <network/TopLevelDomain.h>
+#include <network/DomainTools.h>
 #include <wtf/CurrentTime.h>
 #include <wtf/text/CString.h>
 
@@ -274,7 +274,7 @@
 
                 // Check whether the domain is a top level domain, if it is throw it out
                 // http://publicsuffix.org/list/
-                if (!BlackBerry::Platform::TopLevelDomain::isCookieWritableDomain(realDomain.utf8().data()))
+                if (BlackBerry::Platform::isTopLevelDomain(realDomain.utf8().data()))
                     LOG_AND_DELETE("Invalid cookie %s (domain): it did not pass the top level domain check", cookie.ascii().data());
 
                 res->setDomain(realDomain);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to