Title: [126512] trunk/Tools
- Revision
- 126512
- Author
- [email protected]
- Date
- 2012-08-23 17:31:36 -0700 (Thu, 23 Aug 2012)
Log Message
Replay tests take forever to load
https://bugs.webkit.org/show_bug.cgi?id=94764
Reviewed by Adam Barth.
Don't load about:blank at the beginning. This appears to clog the DRT.
* Scripts/webkitpy/performance_tests/perftest.py:
(ReplayPerfTest.run_single):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126511 => 126512)
--- trunk/Tools/ChangeLog 2012-08-24 00:22:24 UTC (rev 126511)
+++ trunk/Tools/ChangeLog 2012-08-24 00:31:36 UTC (rev 126512)
@@ -1,3 +1,18 @@
+2012-08-23 Ryosuke Niwa <[email protected]>
+
+ Replay tests take forever to load
+ https://bugs.webkit.org/show_bug.cgi?id=94764
+
+ Reviewed by Adam Barth.
+
+ Don't load about:blank at the beginning. This appears to clog the DRT.
+
+ * Scripts/webkitpy/performance_tests/perftest.py:
+ (ReplayPerfTest.run_single):
+ * Scripts/webkitpy/performance_tests/perftest_unittest.py:
+ (TestReplayPerfTest.test_run_single):
+ (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
+
2012-08-23 Kenneth Russell <[email protected]>
Unreviewed, rolling out r126497.
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (126511 => 126512)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-08-24 00:22:24 UTC (rev 126511)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-08-24 00:31:36 UTC (rev 126512)
@@ -319,9 +319,7 @@
_log.error("Web page replay didn't start.")
return None
- super(ReplayPerfTest, self).run_single(driver, "about:blank", time_out_ms)
- _log.debug("Loading the page")
-
+ _log.debug("Web page replay started. Loading the page.")
output = super(ReplayPerfTest, self).run_single(driver, self._url, time_out_ms, should_run_pixel_test=True)
if self.run_failed(output):
return None
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py (126511 => 126512)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py 2012-08-24 00:22:24 UTC (rev 126511)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py 2012-08-24 00:31:36 UTC (rev 126512)
@@ -192,9 +192,8 @@
finally:
actual_stdout, actual_stderr, actual_logs = output_capture.restore_output()
- self.assertEqual(len(loaded_pages), 2)
- self.assertEqual(loaded_pages[0].test_name, 'about:blank')
- self.assertEqual(loaded_pages[1].test_name, 'http://some-test/')
+ self.assertEqual(len(loaded_pages), 1)
+ self.assertEqual(loaded_pages[0].test_name, 'http://some-test/')
self.assertEqual(actual_stdout, '')
self.assertEqual(actual_stderr, '')
self.assertEqual(actual_logs, '')
@@ -259,9 +258,8 @@
finally:
actual_stdout, actual_stderr, actual_logs = output_capture.restore_output()
- self.assertEqual(len(loaded_pages), 2)
- self.assertEqual(loaded_pages[0].test_name, 'about:blank')
- self.assertEqual(loaded_pages[1].test_name, 'http://some-test/')
+ self.assertEqual(len(loaded_pages), 1)
+ self.assertEqual(loaded_pages[0].test_name, 'http://some-test/')
self.assertEqual(actual_stdout, '')
self.assertEqual(actual_stderr, '')
self.assertEqual(actual_logs, 'error: some-test.replay\nsome error\n')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
