Diff
Modified: trunk/LayoutTests/ChangeLog (126524 => 126525)
--- trunk/LayoutTests/ChangeLog 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/ChangeLog 2012-08-24 01:53:54 UTC (rev 126525)
@@ -1,3 +1,24 @@
+2012-08-23 Shinya Kawanaka <[email protected]>
+
+ Needs update tests of Shadow DOM for keygen
+ https://bugs.webkit.org/show_bug.cgi?id=94765
+
+ Reviewed by Dimitri Glazkov.
+
+ Now that the HTMLKeygenElement was AuthroShadowDOM-ready, it's time to update the previous
+ failing tests for AuthroShadowDOM for keygen elements.
+
+ I've updated the failing tests to follow the current implementation and updated the test expectations.
+
+ * fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html:
+ * fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
+ * fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html:
+ * fast/dom/shadow/shadowdom-for-keygen-only-shadow.html:
+ * fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html:
+ * fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
+ * platform/chromium/TestExpectations:
+ * platform/efl/TestExpectations:
+
2012-08-23 Jon Honeycutt <[email protected]>
Update Skipped list and TestExpectations in preparation for making
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -2,9 +2,9 @@
<script src=""
<p>A mixed case of a shadow element and content element.</p>
-<form>
- foobar<div style="margin: 20px">
- <keygen></keygen>
- </div>
- <input id="submit" type="submit" value="Submit">
+<form><!-- margin-top will be cancelled out, so we use padding-top here. -->
+ <div style="margin: 2px 2px 2px; padding-top: 2px; font: -webkit-small-control;"><span style="font: -webkit-small-control;">foobar</span><div style="margin: 20px">
+ <keygen style="margin: 0">
+ </div></div>
</form>
+
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -3,12 +3,12 @@
<p>A mixed case of a shadow element and content element.</p>
<form>
- <keygen id="host">foobar</keygen>
- <input id="submit" type="submit" value="Submit">
+ <keygen id="host">
</form>
<script>
-var host = document.getElementById('host');
+host.appendChild(document.createTextNode('foobar'));
+
var shadowRoot = new WebKitShadowRoot(host);
shadowRoot.innerHTML = "<content></content><div style='margin: 20px'><shadow></shadow></div>"
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -1,8 +1,11 @@
<!DOCTYPE html>
+<html>
+<body>
<script src=""
<p>When the AuthorShadowDOM has only a shadow element, this should be rendered like no Shadow DOM is added.</p>
<form>
- <keygen id="host"></keygen>
- <input id="submit" type="submit" value="Submit">
+ <keygen></keygen>
</form>
+</body>
+</html>
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -1,14 +1,17 @@
<!DOCTYPE html>
+<html>
+<body>
<script src=""
<p>When the AuthorShadowDOM has only a shadow element, this should be rendered like no Shadow DOM is added.</p>
<form>
<keygen id="host"></keygen>
- <input id="submit" type="submit" value="Submit">
</form>
<script>
-var host = document.getElementById('host');
var shadowRoot = new WebKitShadowRoot(host);
-shadowRoot.innerHTML = "<shadow></shadow>"
+var shadow = document.createElement('shadow');
+shadowRoot.appendChild(shadow);
</script>
+</body>
+</html>
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -3,6 +3,6 @@
<p>When the AuthorShadowDOM does not have a Shadow DOM, the content won't be rendered.</p>
<form>
- <div style="display: inline-block; width: 100px; height:30px; margin: 0; padding: 0; border: 0">
- <input id="submit" type="submit" value="Submit">
+ <div style="display: inline-block; width: 100px; height:30px; margin: 0; padding: 0; border: 0"></div>
+ foobar
</form>
Modified: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow.html (126524 => 126525)
--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow.html 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow.html 2012-08-24 01:53:54 UTC (rev 126525)
@@ -1,13 +1,16 @@
<!DOCTYPE html>
+<html>
+<body>
<script src=""
<p>When the AuthorShadowDOM does not have a Shadow DOM, the content won't be rendered.</p>
<form>
- <keygen id="host" style="width: 100px; height:30px; margin: 0; padding: 0; border: 0">
- <input id="submit" type="submit" value="Submit">
+ <keygen id="host" style="width: 100px; height:30px; margin: 0; padding: 0; border: 0"></keygen>
+ foobar
</form>
<script>
-var host = document.getElementById('host');
var shadowRoot = new WebKitShadowRoot(host);
</script>
+</body>
+</html>
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (126524 => 126525)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-24 01:53:54 UTC (rev 126525)
@@ -3243,8 +3243,6 @@
BUGWK91488 : fast/dom/shadow/shadowdom-for-output-only-shadow.html = IMAGE
BUGWK91489 : fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html = IMAGE
BUGWK91489 : fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html = IMAGE
-BUGWK91491 : fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html = IMAGE
-BUGWK91491 : fast/dom/shadow/shadowdom-for-keygen-without-shadow.html = IMAGE
// Requires setUseDeferredFrameLoading() API from LayoutTestController.
BUGWK87652 SKIP : http/tests/appcache/load-from-appcache-defer-resume-crash.html = PASS
Modified: trunk/LayoutTests/platform/efl/TestExpectations (126524 => 126525)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-08-24 01:25:21 UTC (rev 126524)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-08-24 01:53:54 UTC (rev 126525)
@@ -692,8 +692,6 @@
BUGWK91488 : fast/dom/shadow/shadowdom-for-output-only-shadow.html = IMAGE
BUGWK91489 : fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html = IMAGE
BUGWK91489 : fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html = IMAGE
-BUGWK91491 : fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html = IMAGE
-BUGWK91491 : fast/dom/shadow/shadowdom-for-keygen-without-shadow.html = IMAGE
// This test is specific to QuickTime media engine.
BUGWKEFL SKIP : media/video-does-not-loop.html = PASS
