Title: [126533] trunk/Tools
- Revision
- 126533
- Author
- [email protected]
- Date
- 2012-08-23 21:03:31 -0700 (Thu, 23 Aug 2012)
Log Message
leak detection broken after r126247 on mac
https://bugs.webkit.org/show_bug.cgi?id=94893
Unreviewed, build fix.
Adds is_snowleopard(), is_lion back() in for the mac port. We'll
probably need an is_mountainlion() or equivalent at some point,
I'm guessing (but I've deleted the leopard code).
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort.is_snowleopard):
(MacPort.is_lion):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (126532 => 126533)
--- trunk/Tools/ChangeLog 2012-08-24 03:40:35 UTC (rev 126532)
+++ trunk/Tools/ChangeLog 2012-08-24 04:03:31 UTC (rev 126533)
@@ -1,3 +1,21 @@
+2012-08-23 Dirk Pranke <[email protected]>
+
+ leak detection broken after r126247 on mac
+ https://bugs.webkit.org/show_bug.cgi?id=94893
+
+ Unreviewed, build fix.
+
+ Adds is_snowleopard(), is_lion back() in for the mac port. We'll
+ probably need an is_mountainlion() or equivalent at some point,
+ I'm guessing (but I've deleted the leopard code).
+
+ * Scripts/webkitpy/layout_tests/port/leakdetector.py:
+ (LeakDetector._callstacks_to_exclude_from_leaks):
+ * Scripts/webkitpy/layout_tests/port/mac.py:
+ (MacPort):
+ (MacPort.is_snowleopard):
+ (MacPort.is_lion):
+
2012-08-23 Julien Chaffraix <[email protected]>
[Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py (126532 => 126533)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2012-08-24 03:40:35 UTC (rev 126532)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2012-08-24 04:03:31 UTC (rev 126533)
@@ -57,19 +57,8 @@
"Flash_EnforceLocalSecurity", # leaks in Flash plug-in code, rdar://problem/4449747
"ScanFromString", # <http://code.google.com/p/angleproject/issues/detail?id=249> leak in ANGLE
]
- if self._port.is_leopard():
+ if self._port.is_snowleopard():
callstacks += [
- "CFHTTPMessageAppendBytes", # leak in CFNetwork, rdar://problem/5435912
- "sendDidReceiveDataCallback", # leak in CFNetwork, rdar://problem/5441619
- "_CFHTTPReadStreamReadMark", # leak in CFNetwork, rdar://problem/5441468
- "httpProtocolStart", # leak in CFNetwork, rdar://problem/5468837
- "_CFURLConnectionSendCallbacks", # leak in CFNetwork, rdar://problem/5441600
- "DispatchQTMsg", # leak in QuickTime, PPC only, rdar://problem/5667132
- "QTMovieContentView createVisualContext", # leak in QuickTime, PPC only, rdar://problem/5667132
- "_CopyArchitecturesForJVMVersion", # leak in Java, rdar://problem/5910823
- ]
- elif self._port.is_snowleopard():
- callstacks += [
"readMakerNoteProps", # <rdar://problem/7156432> leak in ImageIO
"QTKitMovieControllerView completeUISetup", # <rdar://problem/7155156> leak in QTKit
"getVMInitArgs", # <rdar://problem/7714444> leak in Java
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (126532 => 126533)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-08-24 03:40:35 UTC (rev 126532)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-08-24 04:03:31 UTC (rev 126533)
@@ -98,6 +98,14 @@
def operating_system(self):
return 'mac'
+ # Belongs on a Platform object.
+ def is_snowleopard(self):
+ return self._version == "snowleopard"
+
+ # Belongs on a Platform object.
+ def is_lion(self):
+ return self._version == "lion"
+
def default_child_processes(self):
# FIXME: The Printer isn't initialized when this is called, so using _log would just show an unitialized logger error.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
