Title: [126535] trunk/Source/WebCore
- Revision
- 126535
- Author
- [email protected]
- Date
- 2012-08-23 21:31:34 -0700 (Thu, 23 Aug 2012)
Log Message
Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve
https://bugs.webkit.org/show_bug.cgi?id=94887
Patch by James Robinson <[email protected]> on 2012-08-23
Reviewed by Dirk Pranke.
This makes clang happy. Clang makes me happy. By induction, this makes me happy.
* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore::TouchpadFlingPlatformGestureCurve::debugName):
(WebCore):
* platform/TouchpadFlingPlatformGestureCurve.h:
(TouchpadFlingPlatformGestureCurve):
* platform/WheelFlingPlatformGestureCurve.cpp:
(WebCore::WheelFlingPlatformGestureCurve::debugName):
(WebCore):
* platform/WheelFlingPlatformGestureCurve.h:
(WheelFlingPlatformGestureCurve):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126534 => 126535)
--- trunk/Source/WebCore/ChangeLog 2012-08-24 04:23:10 UTC (rev 126534)
+++ trunk/Source/WebCore/ChangeLog 2012-08-24 04:31:34 UTC (rev 126535)
@@ -1,3 +1,23 @@
+2012-08-23 James Robinson <[email protected]>
+
+ Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve
+ https://bugs.webkit.org/show_bug.cgi?id=94887
+
+ Reviewed by Dirk Pranke.
+
+ This makes clang happy. Clang makes me happy. By induction, this makes me happy.
+
+ * platform/TouchpadFlingPlatformGestureCurve.cpp:
+ (WebCore::TouchpadFlingPlatformGestureCurve::debugName):
+ (WebCore):
+ * platform/TouchpadFlingPlatformGestureCurve.h:
+ (TouchpadFlingPlatformGestureCurve):
+ * platform/WheelFlingPlatformGestureCurve.cpp:
+ (WebCore::WheelFlingPlatformGestureCurve::debugName):
+ (WebCore):
+ * platform/WheelFlingPlatformGestureCurve.h:
+ (WheelFlingPlatformGestureCurve):
+
2012-08-23 Yoshifumi Inoue <[email protected]>
[Forms] Step mismatched value should be editable in multiple field time UI.
Modified: trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp (126534 => 126535)
--- trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp 2012-08-24 04:23:10 UTC (rev 126534)
+++ trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp 2012-08-24 04:31:34 UTC (rev 126535)
@@ -129,6 +129,11 @@
{
}
+const char* TouchpadFlingPlatformGestureCurve::debugName() const
+{
+ return "TouchpadFling";
+}
+
bool TouchpadFlingPlatformGestureCurve::apply(double time, PlatformGestureCurveTarget* target)
{
float displacement;
Modified: trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h (126534 => 126535)
--- trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h 2012-08-24 04:23:10 UTC (rev 126534)
+++ trunk/Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h 2012-08-24 04:31:34 UTC (rev 126535)
@@ -44,8 +44,8 @@
static PassOwnPtr<PlatformGestureCurve> create(const FloatPoint& velocity, float p0, float p1, float p2, float p3, float p4, float curveDuration, IntPoint cumulativeScroll = IntPoint());
virtual ~TouchpadFlingPlatformGestureCurve();
- virtual const char* debugName() const { return "TouchpadFling"; }
- virtual bool apply(double monotonicTime, PlatformGestureCurveTarget*);
+ virtual const char* debugName() const OVERRIDE;
+ virtual bool apply(double monotonicTime, PlatformGestureCurveTarget*) OVERRIDE;
private:
TouchpadFlingPlatformGestureCurve(const FloatPoint& velocity, float p0, float p1, float p2, float p3, float p4, float curveDuration, const IntPoint& cumulativeScroll);
Modified: trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.cpp (126534 => 126535)
--- trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.cpp 2012-08-24 04:23:10 UTC (rev 126534)
+++ trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.cpp 2012-08-24 04:31:34 UTC (rev 126535)
@@ -46,6 +46,11 @@
{
}
+const char* WheelFlingPlatformGestureCurve::debugName() const
+{
+ return "WheelFling";
+}
+
bool WheelFlingPlatformGestureCurve::apply(double time, PlatformGestureCurveTarget* target)
{
// Use a Rayleigh distribution for the curve. This simulates a velocity profile
Modified: trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.h (126534 => 126535)
--- trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.h 2012-08-24 04:23:10 UTC (rev 126534)
+++ trunk/Source/WebCore/platform/WheelFlingPlatformGestureCurve.h 2012-08-24 04:31:34 UTC (rev 126535)
@@ -43,8 +43,8 @@
static PassOwnPtr<PlatformGestureCurve> create(const FloatPoint& velocity);
virtual ~WheelFlingPlatformGestureCurve();
- virtual const char* debugName() const { return "WheelFling"; }
- virtual bool apply(double time, PlatformGestureCurveTarget*);
+ virtual const char* debugName() const OVERRIDE;
+ virtual bool apply(double time, PlatformGestureCurveTarget*) OVERRIDE;
private:
explicit WheelFlingPlatformGestureCurve(const FloatPoint& velocity);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes