Title: [126712] trunk/Source/_javascript_Core
- Revision
- 126712
- Author
- [email protected]
- Date
- 2012-08-26 12:53:09 -0700 (Sun, 26 Aug 2012)
Log Message
DFGGraph.h has a bogus comment about the nature of StorageAccessData
https://bugs.webkit.org/show_bug.cgi?id=95035
Reviewed by Oliver Hunt.
The comment is both wrong (storage access instructions don't reference CheckStructure)
and highly redundant: of course it's the case that two structures may have the same
identifier. Our interference analyses currently don't care about this and make the
conservative assumptions when necessary (same identifier, same object -> must be same
property; same identifier, may be same object -> may be the same property). Better to
remove the bogus comment since the code that operates over this data structure is
fairly self-explanatory already.
* dfg/DFGGraph.h:
(StorageAccessData):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (126711 => 126712)
--- trunk/Source/_javascript_Core/ChangeLog 2012-08-26 19:41:43 UTC (rev 126711)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-08-26 19:53:09 UTC (rev 126712)
@@ -1,3 +1,21 @@
+2012-08-26 Filip Pizlo <[email protected]>
+
+ DFGGraph.h has a bogus comment about the nature of StorageAccessData
+ https://bugs.webkit.org/show_bug.cgi?id=95035
+
+ Reviewed by Oliver Hunt.
+
+ The comment is both wrong (storage access instructions don't reference CheckStructure)
+ and highly redundant: of course it's the case that two structures may have the same
+ identifier. Our interference analyses currently don't care about this and make the
+ conservative assumptions when necessary (same identifier, same object -> must be same
+ property; same identifier, may be same object -> may be the same property). Better to
+ remove the bogus comment since the code that operates over this data structure is
+ fairly self-explanatory already.
+
+ * dfg/DFGGraph.h:
+ (StorageAccessData):
+
2012-08-25 Geoffrey Garen <[email protected]>
Try a little harder to fix the Linux build.
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.h (126711 => 126712)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.h 2012-08-26 19:41:43 UTC (rev 126711)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.h 2012-08-26 19:53:09 UTC (rev 126712)
@@ -53,14 +53,6 @@
struct StorageAccessData {
size_t offset;
unsigned identifierNumber;
-
- // NOTE: the offset and identifierNumber do not by themselves
- // uniquely identify a property. The identifierNumber and a
- // Structure* do. If those two match, then the offset should
- // be the same, as well. For any Node that has a StorageAccessData,
- // it is possible to retrieve the Structure* by looking at the
- // first child. It should be a CheckStructure, which has the
- // Structure*.
};
struct ResolveGlobalData {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
