Title: [126738] trunk/Source/WebCore
- Revision
- 126738
- Author
- [email protected]
- Date
- 2012-08-27 02:45:36 -0700 (Mon, 27 Aug 2012)
Log Message
Regression(r126721): bindings-tests results need to be updated
https://bugs.webkit.org/show_bug.cgi?id=95060
Patch by Christophe Dumez <[email protected]> on 2012-08-27
Reviewed by Kentaro Hara.
Regenerate bindings-tests results after r126721. This change
removed the NULL checks from visitChildren functions.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildren):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::visitChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126737 => 126738)
--- trunk/Source/WebCore/ChangeLog 2012-08-27 09:36:11 UTC (rev 126737)
+++ trunk/Source/WebCore/ChangeLog 2012-08-27 09:45:36 UTC (rev 126738)
@@ -1,3 +1,18 @@
+2012-08-27 Christophe Dumez <[email protected]>
+
+ Regression(r126721): bindings-tests results need to be updated
+ https://bugs.webkit.org/show_bug.cgi?id=95060
+
+ Reviewed by Kentaro Hara.
+
+ Regenerate bindings-tests results after r126721. This change
+ removed the NULL checks from visitChildren functions.
+
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::JSTestObj::visitChildren):
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+ (WebCore::JSTestSerializedScriptValueInterface::visitChildren):
+
2012-08-24 Alexander Pavlov <[email protected]>
Web Inspector: Incorrect property override computation when !important is involved
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (126737 => 126738)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2012-08-27 09:36:11 UTC (rev 126737)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2012-08-27 09:45:36 UTC (rev 126738)
@@ -2593,10 +2593,8 @@
COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren());
Base::visitChildren(thisObject, visitor);
- if (thisObject->m_cachedAttribute1)
- visitor.append(&thisObject->m_cachedAttribute1);
- if (thisObject->m_cachedAttribute2)
- visitor.append(&thisObject->m_cachedAttribute2);
+ visitor.append(&thisObject->m_cachedAttribute1);
+ visitor.append(&thisObject->m_cachedAttribute2);
}
// Constant getters
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (126737 => 126738)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2012-08-27 09:36:11 UTC (rev 126737)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2012-08-27 09:45:36 UTC (rev 126738)
@@ -356,10 +356,8 @@
COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren());
Base::visitChildren(thisObject, visitor);
- if (thisObject->m_cachedValue)
- visitor.append(&thisObject->m_cachedValue);
- if (thisObject->m_cachedReadonlyValue)
- visitor.append(&thisObject->m_cachedReadonlyValue);
+ visitor.append(&thisObject->m_cachedValue);
+ visitor.append(&thisObject->m_cachedReadonlyValue);
}
static inline bool isObservable(JSTestSerializedScriptValueInterface* jsTestSerializedScriptValueInterface)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
