Title: [126740] trunk/Source/WebKit2
Revision
126740
Author
[email protected]
Date
2012-08-27 02:58:31 -0700 (Mon, 27 Aug 2012)

Log Message

[Qt][WK2] REGRESSION(r126067): It made qmltests::DoubleTapToZoom::test_basic() fail
https://bugs.webkit.org/show_bug.cgi?id=94949

Reviewed by Kenneth Rohde Christiansen.

Use JSON to serialize the client rect for the async evaluateJavaScript call.

* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (126739 => 126740)


--- trunk/Source/WebKit2/ChangeLog	2012-08-27 09:58:07 UTC (rev 126739)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-27 09:58:31 UTC (rev 126740)
@@ -1,5 +1,16 @@
 2012-08-27  Simon Hausmann  <[email protected]>
 
+        [Qt][WK2] REGRESSION(r126067): It made qmltests::DoubleTapToZoom::test_basic() fail
+        https://bugs.webkit.org/show_bug.cgi?id=94949
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Use JSON to serialize the client rect for the async evaluateJavaScript call.
+
+        * UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:
+
+2012-08-27  Simon Hausmann  <[email protected]>
+
         [Qt] Fix failing QML2 auto tests due to conflicting signal declaration
         https://bugs.webkit.org/show_bug.cgi?id=95059
 

Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml (126739 => 126740)


--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml	2012-08-27 09:58:07 UTC (rev 126739)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml	2012-08-27 09:58:31 UTC (rev 126740)
@@ -64,8 +64,8 @@
             var result;
 
              webView.experimental.evaluateJavaScript(
-                "document.getElementById('" + id + "').getBoundingClientRect();",
-                function(rect) { webView.resultReceived(); result = rect });
+                "JSON.stringify(document.getElementById('" + id + "').getBoundingClientRect());",
+                function(rect) { webView.resultReceived(); result = JSON.parse(rect); });
             resultSpy.wait();
             return result;
         }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to